Merge lp:~vila/bzr/651706-test-ca-crt into lp:bzr/2.2

Proposed by Vincent Ladeuil on 2010-09-30
Status: Merged
Approved by: Martin Pool on 2010-09-30
Approved revision: 5098
Merged at revision: 5098
Proposed branch: lp:~vila/bzr/651706-test-ca-crt
Merge into: lp:bzr/2.2
Diff against target: 26 lines (+5/-0)
2 files modified
NEWS (+4/-0)
setup.py (+1/-0)
To merge this branch: bzr merge lp:~vila/bzr/651706-test-ca-crt
Reviewer Review Type Date Requested Status
Martin Pool 2010-09-30 Approve on 2010-09-30
Review via email: mp+37109@code.launchpad.net

Commit Message

Add ``tests/ssl_certs/ca.crt to the required test files list.

Description of the Change

The bzrlib/tests/ssl_certs/ca.crt was not installed, making some pycurl https tests fail.

I manually tested that adding this file along the other ones installed fix the issue.

This would help running the tests during the build phase for 2.2 (if needed, the fix is easy enough to backport to the 2.1 and 2.0 series).

To post a comment you must log in.
Martin Pool (mbp) :
review: Approve
Vincent Ladeuil (vila) wrote :

sent to pqm by email

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2010-09-27 15:03:28 +0000
3+++ NEWS 2010-09-30 08:56:02 +0000
4@@ -41,6 +41,10 @@
5 Testing
6 *******
7
8+* Add ``tests/ssl_certs/ca.crt`` to the required test files list. Test
9+ involving the pycurl https test server fail otherwise when running
10+ selftest from an installed version. (Vincent Ladeuil, #651706)
11+
12 * Fix tests that failed when run under ``LANG=C``.
13 (Andrew Bennetts, #632387)
14
15
16=== modified file 'setup.py'
17--- setup.py 2010-08-02 19:56:52 +0000
18+++ setup.py 2010-09-30 08:56:02 +0000
19@@ -66,6 +66,7 @@
20 'package_data': {'bzrlib': ['doc/api/*.txt',
21 'tests/test_patches_data/*',
22 'help_topics/en/*.txt',
23+ 'tests/ssl_certs/ca.crt',
24 'tests/ssl_certs/server_without_pass.key',
25 'tests/ssl_certs/server_with_pass.key',
26 'tests/ssl_certs/server.crt'

Subscribers

People subscribed via source and target branches