Merge lp:~vila/bzr/514301-auth-config-unicode into lp:bzr
Proposed by
Vincent Ladeuil
Status: | Merged |
---|---|
Approved by: | Martin Packman |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6568 |
Proposed branch: | lp:~vila/bzr/514301-auth-config-unicode |
Merge into: | lp:bzr |
Diff against target: |
145 lines (+44/-50) 3 files modified
bzrlib/tests/test_ui.py (+32/-46) bzrlib/ui/text.py (+9/-4) doc/en/release-notes/bzr-2.6.txt (+3/-0) |
To merge this branch: | bzr merge lp:~vila/bzr/514301-auth-config-unicode |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Approve | ||
Review via email: mp+124627@code.launchpad.net |
Commit message
AuthConfig alwaus return user/password as unicode.
Description of the change
This fixes bug #514301 by always returning unicode username/password when
typed by the user (using stdin encoding).
I cleaned up the tests where we enforced the wrong behaviour (let ui
returned encoded strings (including ascii) instead of unicode).
To post a comment you must log in.
Looks good.
We'll get the ui object doing the right thing with unicode, one method at a time...