Code review comment for lp:~vila/bzr/353370-notty-no-term-width

Revision history for this message
Martin Pool (mbp) wrote :

2009/11/24 Vincent Ladeuil <email address hidden>:
>>>>>> "martin" == Martin Pool <email address hidden> writes:
>
>    martin> Review: Disapprove
>
>    martin> Sorry but I really think truncating to any width when
>    martin> there's no terminal to truncate for is bogus.
>
> I would have appreciated a bit more depth for that review (I've been
> acting as patch pilot before the initiative was started so I'm not the
> original author of the patch).

Sorry.

I'll grep for the callers and see if it would be practical to fix them.

--
Martin <http://launchpad.net/~mbp/>

« Back to merge proposal