Code review comment for lp:~vila/bzr/1249732-acceptable-keys-from-config

Richard Wilbur (richard-wilbur) wrote :

Upon further consideration, it looks like it would be useful to add a test of a list of acceptable_keys. If Unicode occurs in E-mail addresses and/or domain names it would also be useful to add a test of with an acceptable_keys list including one or more containing Unicode characters.

review: Needs Fixing

« Back to merge proposal