Code review comment for lp:~vila/bzr/1195783-platform-utf8
Revision history for this message
| Vincent Ladeuil (vila) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
> Do we want to add a test that we do a best-effort on names that aren't
> actually utf-8 but aren't ascii either? (The normal we did was utf8,
> iso-8859-1, but I would be fine with just decode(, 'replace') here).
Fedora had some fun adding such a distribution name but it's still a distribution name, not some random file anybody can put garbage into. Time will tell but I doubt we'll encounter a case where an invalid encoding requires 'replace'.