Merge lp:~vila/bzr-guess/690563-lazy-import into lp:bzr-guess

Proposed by Vincent Ladeuil
Status: Merged
Merged at revision: 6
Proposed branch: lp:~vila/bzr-guess/690563-lazy-import
Merge into: lp:bzr-guess
Diff against target: 28 lines (+11/-3)
1 file modified
__init__.py (+11/-3)
To merge this branch: bzr merge lp:~vila/bzr-guess/690563-lazy-import
Reviewer Review Type Date Requested Status
Martin Pool (community) Approve
John A Meinel Needs Fixing
Review via email: mp+43744@code.launchpad.net

Description of the change

Use lazy imports to make bzrlib.tests.test_import_tariff.TestImportTariffs.test_simple_local happy.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/15/2010 3:55 AM, Vincent Ladeuil wrote:
> Vincent Ladeuil has proposed merging lp:~vila/bzr-guess/690563-lazy-import into lp:bzr-guess.
>
> Requested reviews:
> Bazaar Developers (bzr)
> Related bugs:
> #690563 bzrlib.tests.test_import_tariff.TestImportTariffs.test_simple_local failure
> https://bugs.launchpad.net/bugs/690563
>
>
> Use lazy imports to make bzrlib.tests.test_import_tariff.TestImportTariffs.test_simple_local happy.
>

 review: needs_fixing

I'm pretty sure the module isn't called "patiendiff".

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0I6qYACgkQJdeBCYSNAAPwzQCgi7B1fKT87O9QGbWRNLpNg/ka
/HcAnREcMwrs4ITs7jSiyWbu1CGFgHyP
=lW+y
-----END PGP SIGNATURE-----

review: Needs Fixing
Revision history for this message
Vincent Ladeuil (vila) wrote :

> I'm pretty sure the module isn't called "patiendiff".

Indeed.

Damn typos, damn lack of tests :-/

Fixed and tested manually.

6. By Vincent Ladeuil

Fix typo.

Revision history for this message
Martin Pool (mbp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '__init__.py'
2--- __init__.py 2009-07-26 14:16:55 +0000
3+++ __init__.py 2010-12-15 16:47:12 +0000
4@@ -1,4 +1,4 @@
5-# Copyright (C) 2009 Canonical Ltd
6+# Copyright (C) 2009, 2010 Canonical Ltd
7 #
8 # This program is free software; you can redistribute it and/or modify
9 # it under the terms of the GNU General Public License as published by
10@@ -18,8 +18,16 @@
11
12
13 import traceback
14-from bzrlib import commands, patiencediff, ui
15-
16+from bzrlib import (
17+ commands,
18+ lazy_import,
19+ )
20+lazy_import.lazy_import(globals(), """
21+from bzrlib import (
22+ patiencediff,
23+ ui,
24+ )
25+""")
26
27 # Overrides for common mispellings that heuristics get wrong
28 _overrides = {

Subscribers

People subscribed via source and target branches