Merge lp:~viktor-nagy/openobject-server/repeatInArgument3Fixed into lp:openobject-server

Proposed by ViktorNagy
Status: Rejected
Rejected by: Vo Minh Thu
Proposed branch: lp:~viktor-nagy/openobject-server/repeatInArgument3Fixed
Merge into: lp:openobject-server
Diff against target: 20 lines (+6/-4)
1 file modified
openerp/report/preprocess.py (+6/-4)
To merge this branch: bzr merge lp:~viktor-nagy/openobject-server/repeatInArgument3Fixed
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+62618@code.launchpad.net

Description of the change

If someone uses the third argument of repeatIn in a report (e.g.: [[ repeatIn(sale_order_lines(o), 'l', '{http://openoffice.org/2000/text}section') ]] ), then the parser quotes it, even though it's already quoted.

These double quotes are eliminated in this branch.

To post a comment you must log in.
Revision history for this message
Vo Minh Thu (thu) wrote :

Since you have already a similar merge proposal at https://code.launchpad.net/~toolpart/openobject-server/toolpart/+merge/68793, I will reject this one.

Unmerged revisions

3357. By ViktorNagy

fixed repeatIn with specified tag bug

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/report/preprocess.py'
2--- openerp/report/preprocess.py 2010-05-18 10:32:42 +0000
3+++ openerp/report/preprocess.py 2011-05-27 07:44:33 +0000
4@@ -66,10 +66,12 @@
5 match = html_parents
6 if txt.group(3):
7 match = [txt.group(3)]
8- n = node
9- while n.tag not in match:
10- n = n.getparent()
11- n.set('rml_loop', txt.group(2))
12+ if match[0].startswith("'"):
13+ match[0] = match[0][1:-1]
14+ n2= node
15+ while n2.tag not in match:
16+ n2 = n2.getparent()
17+ n2.set('rml_loop', txt.group(2))
18 return '[['+txt.group(1)+"''"+txt.group(4)+']]'
19 t = _regex1.sub(_sub1, node.text or node.tail)
20 if t == " ":