Merge lp:~vikoadi/switchboard/keyboard-navigation into lp:~elementary-pantheon/switchboard/switchboard
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Danielle Foré | ||||
Approved revision: | 539 | ||||
Merged at revision: | 547 | ||||
Proposed branch: | lp:~vikoadi/switchboard/keyboard-navigation | ||||
Merge into: | lp:~elementary-pantheon/switchboard/switchboard | ||||
Diff against target: |
288 lines (+193/-10) 2 files modified
src/CategoryView.vala (+165/-8) src/Switchboard.vala (+28/-2) |
||||
To merge this branch: | bzr merge lp:~vikoadi/switchboard/keyboard-navigation | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Danielle Foré | ux | Approve | |
Artem Anufrij (community) | code style | Needs Fixing | |
David Gomes (community) | Needs Fixing | ||
elementary UX | ux | Pending | |
Review via email: mp+241757@code.launchpad.net |
Commit message
Keyboard navigation throughout switchboard
- using arrow key will move selection
- using Return key to activate selection
- Alt+left key will bring back to CategoryView
- typing other key will start search
- press enter from startbar will activate first result
Description of the change
Keyboard navigation throughout switchboard
- using arrow key will move selection
- using Return key to activate selection
- Alt+left key will bring back to CategoryView
- typing other key will start search
- press enter from startbar will activate first result
please note that current elementary theme doesnt have focus style so either use Adwaita or comment
GtkIconView.
GtkIconView.
background-
color: @text_color;
}
in gtk-widgets.css theme file
"c", "d", "sel" and "dist" aren't really good variable names.
Also, this needs design input I'm pretty sure.