Merge lp:~vikoadi/switchboard-plug-notifications/notification-scroll into lp:~elementary-pantheon/switchboard-plug-notifications/trunk

Proposed by Viko Adi Rahmawan
Status: Merged
Approved by: Marcus Wichelmann
Approved revision: 60
Merged at revision: 60
Proposed branch: lp:~vikoadi/switchboard-plug-notifications/notification-scroll
Merge into: lp:~elementary-pantheon/switchboard-plug-notifications/trunk
Diff against target: 22 lines (+5/-1)
1 file modified
src/Widgets/AppsView.vala (+5/-1)
To merge this branch: bzr merge lp:~vikoadi/switchboard-plug-notifications/notification-scroll
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+244384@code.launchpad.net

Commit message

Applist moved to Gtk.ScrolledWindow

Description of the change

add applist into Gtk.ScrolledWindow so if user have a lot notification it doesnt flood out of screen

To post a comment you must log in.
Revision history for this message
Marcus Wichelmann (l-admin-3) wrote :

Nice, I have forgotten that... ;)

Can you please move the var scrolled_window to the top as "private Gtk.ScrolledWindow scrolled_window"? Just vor consistency.

60. By Viko Adi Rahmawan

move scrolled_window to local variable

Revision history for this message
Viko Adi Rahmawan (vikoadi) wrote :

done

Revision history for this message
Marcus Wichelmann (l-admin-3) wrote :

Works and does its job, well done!

I hope the bot will merge that automatically...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/AppsView.vala'
2--- src/Widgets/AppsView.vala 2014-11-16 17:09:31 +0000
3+++ src/Widgets/AppsView.vala 2014-12-11 16:31:16 +0000
4@@ -22,6 +22,7 @@
5 public class Widgets.AppsView : Granite.Widgets.ThinPaned {
6 private Gtk.Box sidebar;
7
8+ private Gtk.ScrolledWindow scrolled_window;
9 public AppList applist;
10 private Footer footer;
11
12@@ -47,7 +48,10 @@
13 content.add_named (appsettings, "app-settings");
14 content.add_named (do_not_disturb_info, "do-not-disturb");
15
16- sidebar.pack_start (applist, true, true);
17+ scrolled_window = new Gtk.ScrolledWindow (null, null);
18+ scrolled_window.add (applist);
19+
20+ sidebar.pack_start (scrolled_window, true, true);
21 sidebar.pack_start (new Gtk.Separator (Gtk.Orientation.HORIZONTAL), false, true);
22 sidebar.pack_start (footer, false, true);
23

Subscribers

People subscribed via source and target branches

to all changes: