Noise

Merge lp:~vikoadi/noise/playfirstsearch into lp:~elementary-apps/noise/trunk

  1. playfirstsearch
  2. Merge into trunk
Proposed by Viko Adi Rahmawan
Status: Work in progress
Proposed branch: lp:~vikoadi/noise/playfirstsearch
Merge into: lp:~elementary-apps/noise/trunk
Diff against target: 14 lines (+0/-3)
1 file modified
src/PlaybackManager.vala (+0/-3)
To merge this branch: bzr merge lp:~vikoadi/noise/playfirstsearch
Reviewer Review Type Date Requested Status
AnSukkal (community) testing Approve
elementary Apps team Pending
Review via email: mp+223226@code.launchpad.net

Description of the change

when you search for a query and press enter, first music in list should be playing. this branch fix the problem it doesnt work in shuffle mode.

To post a comment you must log in.
Revision history for this message
AnSukkal (ansukkal) wrote :

Everything works as explained except when shuffle is enabled.

review: Approve (testing)
Reply
Revision history for this message
Viko Adi Rahmawan (vikoadi) wrote :

In fact that shuffle is the only thing this branch should solve. But this come from old branch so it doesnt work anymore.
I hope that Carl's branch will fix this.

Reply

Unmerged revisions

1607. By Viko Adi Rahmawan

merge trunk

1606. By Viko Adi Rahmawan

enter to play first music in list while searching and shuffle

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/PlaybackManager.vala'
2--- src/PlaybackManager.vala 2014-03-14 15:48:01 +0000
3+++ src/PlaybackManager.vala 2014-06-16 11:51:28 +0000
4@@ -190,10 +190,7 @@
5 }
6
7 public Media mediaFromCurrentIndex (int index_in_current) {
8- if(Settings.Main.get_default ().shuffle_mode == Noise.Settings.Shuffle.OFF)
9 return _current.get (index_in_current);
10- else
11- return _current_shuffled.get (index_in_current);
12 }
13
14 public Gee.Collection<Media> current_media () {

Subscribers

People subscribed via source and target branches