Audience

Merge lp:~vikoadi/audience/playlist-tooltip into lp:~audience-members/audience/trunk

  1. playlist-tooltip
  2. Merge into trunk
Proposed by Viko Adi Rahmawan
Status: Merged
Approved by: Robert Roth
Approved revision: 405
Merged at revision: 405
Proposed branch: lp:~vikoadi/audience/playlist-tooltip
Merge into: lp:~audience-members/audience/trunk
Diff against target: 16 lines (+2/-1)
1 file modified
src/Widgets/Playlist.vala (+2/-1)
To merge this branch: bzr merge lp:~vikoadi/audience/playlist-tooltip
Reviewer Review Type Date Requested Status
Robert Roth (community) Approve
elementary UX ux Pending
Review via email: mp+236219@code.launchpad.net

Commit message

Set playlist ellipsize to middle and show playlist item tooltip (lp:1362682)

Description of the change

* set playlist text ellipsized to MIDDLE
* show tooltip on playlist item

To post a comment you must log in.
Revision history for this message
Robert Roth (evfool) wrote :

Looks fine, works fine.

review: Approve
Revision history for this message
Robert Roth (evfool) wrote :

Marked as Needs Review, as based on the bug comments we might still need UX Team approval.

Revision history for this message
Robert Roth (evfool) wrote :

Got Slack approval from danrabbit, approving.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/Playlist.vala'
2--- src/Widgets/Playlist.vala 2014-08-09 01:13:20 +0000
3+++ src/Widgets/Playlist.vala 2014-09-27 07:45:35 +0000
4@@ -43,10 +43,11 @@
5 get_selection ().mode = Gtk.SelectionMode.NONE;
6
7 var text_render = new Gtk.CellRendererText ();
8- text_render.ellipsize = Pango.EllipsizeMode.END;
9+ text_render.ellipsize = Pango.EllipsizeMode.MIDDLE;
10
11 this.insert_column_with_attributes (-1, "Playing", new Gtk.CellRendererPixbuf (), "gicon", Columns.PLAYING);
12 this.insert_column_with_attributes (-1, "Title", text_render, "text", Columns.TITLE);
13+ this.set_tooltip_column (1);
14
15 this.row_activated.connect ((path ,col) => {
16 Gtk.TreeIter iter;

Subscribers

People subscribed via source and target branches