Merge lp:~vikoadi/audience/fix-1190516 into lp:~audience-members/audience/trunk

[Danielle Foré]

[Cody Garver (codygarver)]

Still happens for me if I seek.

Play video > show playlist > seek to some random part of the video > hide playlist > observe the controls remain

review: Needs Fixing

[Avi Romanoff (aroman)]

also the code style needs to be updated -- there should be a space between } and else and those comments should not be indented. they should be horizontally aligned with video_player.unlock_hide();

review: Needs Fixing

[lp:~vikoadi/audience/fix-1190516]

339. By Viko Adi Rahmawan on 2014-05-26

fix code style

[Viko Adi Rahmawan (vikoadi)]

It seems to be leave_event and enter_event of Clutter.Actor not responsive enough to handle mouse leaving fast enough from the sidebar button, I can do nothing about it. Is there any idea for more sensitive leave_event?
 Audience 3.12 branch doesnt have this issues, so if that branch is going to be merge, there is no reason for fixing this bug.

[Danielle Foré (danrabbit)]

I agree it's not really worth spending time on this since we'll replace it with the Gtk solution

[Cody Garver (codygarver)]

Rejected because this was superseded by the gtk 3.12 branch that got merged in trunk

Unmerged revisions

339. By Viko Adi Rahmawan on 2014-05-26

fix code style

338. By Viko Adi Rahmawan on 2014-05-23

mae sure we do unlock_hide when mainwindow.focus_in_event dont get called

=== modified file 'src/Audience.vala'
--- src/Audience.vala	2014-05-25 13:34:00 +0000
+++ src/Audience.vala	2014-05-26 17:15:49 +0000
@@ -471,6 +471,11 @@
                     video_player.lock_hide ();
 
                     return true;
+                } else if (moving) {
+                    /*make sure we do unlock because sometime main_window dont 
+                    get focused, focus_in_event not being called */
+                    video_player.unlock_hide ();
+                    moving = false;
                 }
                 return false;
             });

=== modified file 'src/Widgets/ControlsBar.vala'
--- src/Widgets/ControlsBar.vala	2013-05-19 17:10:26 +0000
+++ src/Widgets/ControlsBar.vala	2014-05-26 17:15:49 +0000
@@ -134,4 +134,4 @@
         }
     }
 
-}
+}
\ No newline at end of file