Merge lp:~viking.redwolf/ubuntu/oneiric/lubuntu-artwork/lubuntu-artwork-fix-877293 into lp:ubuntu/oneiric/lubuntu-artwork

Proposed by Redwolf
Status: Superseded
Proposed branch: lp:~viking.redwolf/ubuntu/oneiric/lubuntu-artwork/lubuntu-artwork-fix-877293
Merge into: lp:ubuntu/oneiric/lubuntu-artwork
Diff against target: 47 lines (+16/-2)
3 files modified
debian/changelog (+14/-0)
usr/share/themes/Lubuntu-default/gtk-2.0/gtkrc (+1/-1)
usr/share/themes/Lubuntu-default/gtk-3.0/gtk-buttons.css (+1/-1)
To merge this branch: bzr merge lp:~viking.redwolf/ubuntu/oneiric/lubuntu-artwork/lubuntu-artwork-fix-877293
Reviewer Review Type Date Requested Status
Julien Lavergne Pending
Review via email: mp+82322@code.launchpad.net

Description of the change

This is a syntax correction that avoids terminal dropped errors when opening gedit and some other gtk3 apps.

To post a comment you must log in.
Revision history for this message
Julien Lavergne (gilir) wrote :

Thanks Rafael. I'm ok with the change, but I don't think we should include it in Oneiric.
Now, only fixes for important bugs are allow in Oneiric. I think this error is harmless, so I don't think it's necessary for Oneiric. But, it makes sense to fix it in Precise. Could you do another merge proposal, but against lp:~lubuntu-desktop/+junk/lubuntu-artwork ? Thanks.

Revision history for this message
Redwolf (viking.redwolf) wrote :

Seems logic. I'll try to merge to that branch.

 <http://lubuntublog.blogspot.com/> <http://www.lubuntu.net/>

2011/11/16 Julien Lavergne <email address hidden>

> Thanks Rafael. I'm ok with the change, but I don't think we should include
> it in Oneiric.
> Now, only fixes for important bugs are allow in Oneiric. I think this
> error is harmless, so I don't think it's necessary for Oneiric. But, it
> makes sense to fix it in Precise. Could you do another merge proposal, but
> against lp:~lubuntu-desktop/+junk/lubuntu-artwork ? Thanks.
> --
>
> https://code.launchpad.net/~rafaellaguna/ubuntu/oneiric/lubuntu-artwork/lubuntu-artwork-fix-877293/+merge/82322
> You are the owner of
> lp:~rafaellaguna/ubuntu/oneiric/lubuntu-artwork/lubuntu-artwork-fix-877293.
>

Unmerged revisions

20. By Redwolf

* usr/share/themes/Lubuntu-default/
 - Correct gtk-button border properties syntax (LP: #877293)

19. By Julien Lavergne

* usr/share/themes/Lubuntu-default/
 - Disable inset text style, to reduce CPU usage (LP: #878958)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-09-25 01:13:54 +0000
3+++ debian/changelog 2011-11-15 21:34:26 +0000
4@@ -1,3 +1,17 @@
5+lubuntu-artwork (0.19ubuntu1) oneiric; urgency=low
6+
7+ * usr/share/themes/Lubuntu-default/
8+ - Correct gtk-button border properties syntax (LP: #877293)
9+
10+ -- 神癒礁湖 <rafaellaguna@ubuntu.com> Tue, 15 Nov 2011 22:23:36 +0100
11+
12+lubuntu-artwork (0.19) precise; urgency=low
13+
14+ * usr/share/themes/Lubuntu-default/
15+ - Disable inset text style, to reduce CPU usage (LP: #878958)
16+
17+ -- Julien Lavergne <gilir@ubuntu.com> Fri, 28 Oct 2011 13:39:35 +0200
18+
19 lubuntu-artwork (0.18) oneiric; urgency=low
20
21 * usr/share/themes/Lubuntu-default/
22
23=== modified file 'usr/share/themes/Lubuntu-default/gtk-2.0/gtkrc'
24--- usr/share/themes/Lubuntu-default/gtk-2.0/gtkrc 2011-08-21 00:20:13 +0000
25+++ usr/share/themes/Lubuntu-default/gtk-2.0/gtkrc 2011-11-15 21:34:26 +0000
26@@ -156,7 +156,7 @@
27 stepperstyle = 1 # 0 = standard, 1 = integrated stepper handles, 2 = unknown
28 progressbarstyle = 0 # 0 = nothing, 1 = stripes, 2 = lines
29 shadow_shades = {0.5, 0.0} # gradient for shadows.
30- textstyle = 1 # 0 = normal text, 1 = inset
31+ textstyle = 0 # 0 = normal text, 1 = inset
32 toolbarstyle = 2 # 0 = flat, 1 = glassy, 2 = gradient
33 trough_shades = {0.98, 1.06} # draw gradient on trough of GtkScrollbar and GtkProgressbar
34 }
35
36=== modified file 'usr/share/themes/Lubuntu-default/gtk-3.0/gtk-buttons.css'
37--- usr/share/themes/Lubuntu-default/gtk-3.0/gtk-buttons.css 2011-08-21 00:20:13 +0000
38+++ usr/share/themes/Lubuntu-default/gtk-3.0/gtk-buttons.css 2011-11-15 21:34:26 +0000
39@@ -156,7 +156,7 @@
40 ************/
41 column-header .button {
42 border-radius: 0;
43- padding: -1 2;
44+ padding: 1 2;
45 background-image: -gtk-gradient (linear,
46 left top, left bottom,
47 from (shade (@listview_header_gradient_a,1.00)),

Subscribers

People subscribed via source and target branches

to all changes: