RemoteCP Panel

Merge lp:~vierbergenlars/remotecp-panel/edit-database-details into lp:remotecp-panel/1.x

  1. edit-database-details
  2. Merge into 1.x
Proposed by Lars Vierbergen
Status: Merged
Approved by: Lars Vierbergen
Approved revision: 68
Merged at revision: 70
Proposed branch: lp:~vierbergenlars/remotecp-panel/edit-database-details
Merge into: lp:remotecp-panel/1.x
Diff against target: 11 lines (+0/-1)
1 file modified
system/database.php (+0/-1)
To merge this branch: bzr merge lp:~vierbergenlars/remotecp-panel/edit-database-details
Reviewer Review Type Date Requested Status
Lars Vierbergen Approve
Review via email: mp+48347@code.launchpad.net

This proposal supersedes a proposal from 2011-02-01.

Description of the change

Implements https://blueprints.launchpad.net/remotecp-panel/+spec/edit-database-details.
Forgot to delete something.

To post a comment you must log in.
Revision history for this message
Lars Vierbergen (vierbergenlars) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Lars Vierbergen (vierbergenlars) wrote : Posted in a previous version of this proposal

The module throws a notice about Notice: Undefined index: function in G:\Apache\xampp\htdocs\dev\remotecp-panel_edit-database-details\system\database.php on line 78

review: Needs Fixing
Revision history for this message
Lars Vierbergen (vierbergenlars) wrote : Posted in a previous version of this proposal

Is ok now. (Changed function order)

review: Approve
Revision history for this message
Lars Vierbergen (vierbergenlars) wrote :

Looks OK now

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'system/database.php'
2--- system/database.php 2011-02-01 19:39:55 +0000
3+++ system/database.php 2011-02-02 16:59:10 +0000
4@@ -164,7 +164,6 @@
5 }
6 }
7 else {
8- var_dump('UPDATE `remote_databases` SET `host`="'.$_POST['conn_host'].'", `accesstype`='.$_POST['conn_type'].', `user`="'.$_POST['conn_user'].'", `password`="'.$_POST['conn_pass'].'" WHERE `key`="'.$remote_session->dbkey.'"');
9 $local_connection->query('UPDATE `remote_databases` SET `host`="'.$_POST['conn_host'].'", `accesstype`='.$_POST['conn_type'].', `user`="'.$_POST['conn_user'].'", `password`="'.$_POST['conn_pass'].'" WHERE `key`="'.$remote_session->dbkey.'"');
10 echo "true";
11 }

Subscribers

People subscribed via source and target branches

to all changes: