Merge lp:~vierbergenlars/remotecp-panel/add-database-user into lp:remotecp-panel/1.x

Proposed by Lars Vierbergen
Status: Merged
Approved by: Lars Vierbergen
Approved revision: 66
Merged at revision: 65
Proposed branch: lp:~vierbergenlars/remotecp-panel/add-database-user
Merge into: lp:remotecp-panel/1.x
Prerequisite: lp:~vierbergenlars/remotecp-panel/remote_session
Diff against target: 74 lines (+41/-9)
1 file modified
system/database.php (+41/-9)
To merge this branch: bzr merge lp:~vierbergenlars/remotecp-panel/add-database-user
Reviewer Review Type Date Requested Status
Lars Vierbergen Approve
Review via email: mp+47937@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Lars Vierbergen (vierbergenlars) :
review: Approve
Revision history for this message
Lars Vierbergen (vierbergenlars) wrote :

Errors in parent branch.

review: Needs Fixing
Revision history for this message
Lars Vierbergen (vierbergenlars) wrote :

In this branch, there are also some errors. All $remote_connection should be $local_connection!!!

review: Needs Fixing
66. By Lars Vierbergen

Bug fixes in the database adminstration page

Revision history for this message
Lars Vierbergen (vierbergenlars) wrote :

All fixed right now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'system/database.php'
2--- system/database.php 2011-01-30 17:23:45 +0000
3+++ system/database.php 2011-01-31 16:32:58 +0000
4@@ -14,11 +14,8 @@
5 }
6 if(!RDB&&!isset($_GET['function'])) //We are not in a remote database
7 $_GET['function']='create';
8-if(RDB&&!isset($_GET['function'])) { //We are in a remote database
9- if($_GET['control']=='admin') $_GET['function']='admin'; //Control admin
10-}
11
12-if($_GET['function']=='create') {
13+if(!RDB&&$_GET['function']=='create') {
14 if(!isset($_POST['conn_host'])) {
15 echo "
16 <form method='POST' onsubmit='db.create.send(this); return false'>
17@@ -78,7 +75,7 @@
18 }
19 }
20 }
21-else if($_GET['function']=="help") {
22+else if(!RDB&&$_GET['function']=="help") {
23 $name=$_GET['name'];
24 switch($_GET['name']) {
25 case 'conn_type':
26@@ -114,8 +111,43 @@
27 }
28
29 }
30-else if($_GET['function']=='admin') {
31- ?>
32-
33- <?php
34+else if(RDB&&$_GET['control']=='admin'&&$remote_session->isAdmin()) {
35+ if(!isset($_GET['function'])) {
36+ $q=$local_connection->query('SELECT * FROM `remote_databases_assignments` WHERE `key`="'.$remote_session->dbkey.'"') ?>
37+ <table><tr><th><?php echo $t->_('User'); ?></th><th><?php echo $t->_('Lv.'); ?></th><th><?php echo $t->_('Delete'); ?></th></tr>
38+ <?php while($users=$q->fetch_assoc()) { ?>
39+ <tr><td><img src="<?php echo URL_IMG; ?>/Silk/user.png"> <?php echo $users['username']; ?></td><td<?php if($users['username']!=$session->username) {?> ondblclick='db.admin.user.editlvl.expand("<?php echo $users['username']; ?>",this)'<?php } ?>><?php echo $users['level'] ?></td><td><?php if($users['username']!=$session->username) {?><a onclick='db.admin.user.delete("<?php echo $users['username']; ?>")'><img src="<?php echo URL_IMG; ?>/Silk/delete.png" alt="<?php echo $t->_('Delete'); ?>" title="<?php echo $t->_('Revoke user privileges'); ?>"></a><?php } ?></td></tr>
40+ <?php } ?>
41+ <tr><td colspan='3'><img src="<?php echo URL_IMG; ?>/Silk/user_add.png" alt="+" title="<?php echo $t->_('Add user'); ?>"> <input type='text' onclick='openusers(this)'></td><td><a onclick='db.admin.user.add(this);'><img src="<?php echo URL_IMG; ?>/Silk/add.png" alt="<?php echo $t->_('Add'); ?>" title="<?php echo $t->_('Add new user'); ?>"></a></td></tr>
42+ </table>
43+ <?php
44+}
45+ else if($_GET['function']=='editlvl') {
46+ if($local_connection->query('UPDATE `remote_databases_assignments` SET `level`='.$_GET['lvl'].' WHERE `username`=\''.$_GET['user'].'\' AND `key`=\''.$remote_session->dbkey.'\'')) {
47+ echo "true";
48+ }
49+ else {
50+ echo "false";
51+ }
52+ }
53+ else if($_GET['function']=='deleteuser') {
54+ if($local_connection->query('DELETE FROM `remote_databases_assignments` WHERE `username`=\''.$_POST['username'].'\' AND `key`=\''.$remote_session->dbkey.'\'')) {
55+ echo "true";
56+ }
57+ else {
58+ echo "false";
59+ }
60+ }
61+ else if($_GET['function']=="adduser") {
62+ if(!$database->usernameTaken($_POST['username'])) {
63+ echo "false";
64+ exit;
65+ }
66+ if($local_connection->query('INSERT INTO `remote_databases_assignments` VALUES(\''.$remote_session->dbkey.'\',\''.$_POST['username'].'\',1)')) {
67+ echo "true";
68+ }
69+ else {
70+ echo "false";
71+ }
72+ }
73 }
74\ No newline at end of file

Subscribers

People subscribed via source and target branches

to all changes: