Merge lp:~victor-oc/ubuntu-api-website/trunk into lp:ubuntu-api-website
Status: | Merged |
---|---|
Approved by: | John Vrbanac on 2012-10-19 |
Approved revision: | no longer in the source branch. |
Merged at revision: | 88 |
Proposed branch: | lp:~victor-oc/ubuntu-api-website/trunk |
Merge into: | lp:ubuntu-api-website |
Diff against target: |
389 lines (+306/-7) 11 files modified
DEVELOPMENT (+6/-2) distro/models.py (+23/-1) distro/urls.py (+8/-0) distro/views.py (+29/-1) distro_data.json (+161/-0) lang/models.py (+9/-1) support/models.py (+22/-1) templates/distro.html (+16/-0) templates/index.html (+15/-0) templates/release.html (+15/-0) urls.py (+2/-1) |
To merge this branch: | bzr merge lp:~victor-oc/ubuntu-api-website/trunk |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John Vrbanac | 2012-09-22 | Approve on 2012-10-19 | |
Review via email:
|
Description of the change
Created the models for distro/
Created views for distro and ditrorelease.
Added distro_data.json with some initial distro models that can be loaded [included instructions in DEVELOPMENT]
- 85. By Michael Hall on 2012-09-22
-
Add juju charm, use juju deploy --repository=
./charms/ local:precise/ ubuntu- api-website
- 86. By John Vrbanac on 2012-10-07
-
Adding docbook to html xsl transform on the class view
- 87. By John Vrbanac on 2012-10-07
-
Forgot to remove pdb import on last commit
Victor Choueiri (victor-oc) wrote : | # |
Thanks John,
I've just added a simple implementation for the view/template that will sort this [was just returning None earlier] - The call shouldn't be failing anymore, although the page will be empty since none of the PlatformItem objects have actually been created.
John Vrbanac (john.vrbanac) wrote : | # |
Victor,
I finally got around to checking out your changes last night. Thanks for fixing that stacktrace! Quick question, with this change, how does a person access the actual api references now? I didn't see the links under a given distro version.
Thanks for your contribution!
Victor Choueiri (victor-oc) wrote : | # |
John,
Thanks for spending time on this.
Unfortunately there was no way to access the full listing: following the wireframes over at https:/
As for providing links under the distros, that would be what is documented as the Release Page [https:/
Just to clarify: this merge request tries to cover the following Work_Items laid out at https:/
Distro model
DistroRelease model
PlatformSection model
PlatformItem model
ProgrammingLang model
LanguageNamespace model
RelatedQuestion model
RelatedTutorial model
RelatedSnipped model
RelatedImage model
Index view
Distro view
John Vrbanac (john.vrbanac) wrote : | # |
Victor,
Awesome! Yeah, my major concern was preventing access to those api views until everything is hooked up. I'm assuming that we'll eventually need a way of binding specific GIRs to a given Ubuntu release, but until then then the /all link should work fine.
Regarding the PlatformSection info:
Considering that the GIR files don't give us the information we need to create the PlatformSection information on-the-fly, I'm guessing that we'll just have to manually map the namespaces to a given PlatformSection and then anything that isn't mapped gets put into a generic "Other" section.
Thanks again for your hard work! I'll go ahead and merge this over my lunch break today.
- 88. By John Vrbanac on 2012-10-19
-
Accepting Victor's merge request.
Michael Hall (mhall119) wrote : | # |
I've added an initial list of PlatformSections for Ubuntu that can be used to pre-populate the database: https:/
Victor,
I checked out a fresh version of your branch and followed the modified instructions. When I attempted to use the site it gives me the following trace:
http:// paste.ubuntu. com/1264963/