Code review comment for lp:~victor-launchpad/network-manager-applet/bugfix-lp-386900

Revision history for this message
Martin Pitt (pitti) wrote :

Indeed we don't want to apply this in Ubuntu without it being applied upstream first, otherwise we'd have a permanent delta on user-visible strings. This would keep breaking all translations.

Also, please don't drop the interface name from the string, as it's not uncommon to have more than one. I think "wired connection (eth0)" is a good enough compromise.

review: Disapprove

« Back to merge proposal