Merge ~vicamo/ubuntu/+source/vision-drivers:bug-2134604/upstream-WW46.3_25_ptl_pv-release/resolute/mp into ubuntu/+source/vision-drivers:ubuntu/devel

Proposed by You-Sheng Yang
Status: Merged
Merge reported by: You-Sheng Yang
Merged at revision: 11d023dfb9b6f6cb2957b52e495b0e2f85b19018
Proposed branch: ~vicamo/ubuntu/+source/vision-drivers:bug-2134604/upstream-WW46.3_25_ptl_pv-release/resolute/mp
Merge into: ubuntu/+source/vision-drivers:ubuntu/devel
Prerequisite: ~vicamo/ubuntu/+source/vision-drivers:bug-2134604/upstream-WW46.3_25_ptl_pv-release/resolute/mp-prerequisite
Diff against target: 180 lines (+141/-0)
6 files modified
debian/changelog (+12/-0)
debian/patches/backport-fix-build-against-kernels-v6.1.patch (+34/-0)
debian/patches/backport-fix-build-against-kernels-v6.11.patch (+42/-0)
debian/patches/backport-fix-build-against-kernels-v6.3.patch (+28/-0)
debian/patches/dkms-specify-BUILD_EXCLUSIVE_KERNEL_MIN.patch (+21/-0)
debian/patches/series (+4/-0)
Reviewer Review Type Date Requested Status
Ubuntu Kernel DKMS Uploaders Pending
Review via email: mp+497623@code.launchpad.net

Commit message

* New upstream WW46.3_25_ptl_pv tag release (LP: #2134604)

* Fix build failures against old kernels
  - backport: fix build against kernels < v6.11
  - backport: fix build against kernels < v6.3
  - backport: fix build against kernels < v6.1
  - dkms: specify BUILD_EXCLUSIVE_KERNEL_MIN

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index f5b62a0..48dbe50 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,15 @@
6+vision-drivers (0~git202511121832.a8d772f2-0ubuntu1) resolute; urgency=medium
7+
8+ * New upstream WW46.3_25_ptl_pv tag release (LP: #2134604)
9+
10+ * Fix build failures against old kernels
11+ - backport: fix build against kernels < v6.11
12+ - backport: fix build against kernels < v6.3
13+ - backport: fix build against kernels < v6.1
14+ - dkms: specify BUILD_EXCLUSIVE_KERNEL_MIN
15+
16+ -- You-Sheng Yang <vicamo@gmail.com> Tue, 16 Dec 2025 18:02:32 +0800
17+
18 vision-drivers (0~git202506061730.92a717e0-0ubuntu1) questing; urgency=medium
19
20 * New upstream ww23_25_ptl_post_Beta_Vision tag release (LP: #2101850)
21diff --git a/debian/patches/backport-fix-build-against-kernels-v6.1.patch b/debian/patches/backport-fix-build-against-kernels-v6.1.patch
22new file mode 100644
23index 0000000..a4f39dd
24--- /dev/null
25+++ b/debian/patches/backport-fix-build-against-kernels-v6.1.patch
26@@ -0,0 +1,34 @@
27+From: You-Sheng Yang <vicamo@gmail.com>
28+Date: Tue, 16 Dec 2025 21:11:14 +0800
29+Subject: backport: fix build against kernels < v6.1
30+
31+v6.1-rc1 commit ed5c2f5fd10dd ("i2c: Make remove callback return void")
32+brings this kernel i2c driver API change.
33+
34+Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
35+---
36+ drivers/misc/icvs/intel_cvs.c | 8 ++++++++
37+ 1 file changed, 8 insertions(+)
38+
39+diff --git a/drivers/misc/icvs/intel_cvs.c b/drivers/misc/icvs/intel_cvs.c
40+index 4b6b8f0..f2fd314 100644
41+--- a/drivers/misc/icvs/intel_cvs.c
42++++ b/drivers/misc/icvs/intel_cvs.c
43+@@ -255,9 +255,17 @@ static void cvs_common_remove(struct device *dev, bool is_i2c)
44+ }
45+ }
46+
47++#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 1, 0)
48++static int cvs_i2c_remove(struct i2c_client *i2c)
49++#else
50+ static void cvs_i2c_remove(struct i2c_client *i2c)
51++#endif
52+ {
53+ cvs_common_remove(&i2c->dev, true);
54++
55++#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 1, 0)
56++ return 0;
57++#endif
58+ }
59+
60+ #if LINUX_VERSION_CODE < KERNEL_VERSION(6, 11, 0)
61diff --git a/debian/patches/backport-fix-build-against-kernels-v6.11.patch b/debian/patches/backport-fix-build-against-kernels-v6.11.patch
62new file mode 100644
63index 0000000..237f1e5
64--- /dev/null
65+++ b/debian/patches/backport-fix-build-against-kernels-v6.11.patch
66@@ -0,0 +1,42 @@
67+From: You-Sheng Yang <vicamo@gmail.com>
68+Date: Tue, 16 Dec 2025 18:33:25 +0800
69+Subject: backport: fix build against kernels < v6.11
70+
71+v6.11-rc1 commit 0edb555a65d1e ("platform: Make platform_driver::remove()
72+return void") causes build failure.
73+
74+Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
75+---
76+ drivers/misc/icvs/intel_cvs.c | 9 +++++++++
77+ 1 file changed, 9 insertions(+)
78+
79+diff --git a/drivers/misc/icvs/intel_cvs.c b/drivers/misc/icvs/intel_cvs.c
80+index e85652b..0fb0420 100644
81+--- a/drivers/misc/icvs/intel_cvs.c
82++++ b/drivers/misc/icvs/intel_cvs.c
83+@@ -14,6 +14,7 @@
84+ #include <linux/fs.h>
85+ #include <linux/file.h>
86+ #include <linux/vmalloc.h>
87++#include <linux/version.h>
88+
89+ #include "cvs_gpio.h"
90+ #include "intel_cvs_update.h"
91+@@ -259,9 +260,17 @@ static void cvs_i2c_remove(struct i2c_client *i2c)
92+ cvs_common_remove(&i2c->dev, true);
93+ }
94+
95++#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 11, 0)
96++static int cvs_platform_remove(struct platform_device *pdev)
97++#else
98+ static void cvs_platform_remove(struct platform_device *pdev)
99++#endif
100+ {
101+ cvs_common_remove(&pdev->dev, false);
102++
103++#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 11, 0)
104++ return 0;
105++#endif
106+ }
107+
108+ int cvs_read_i2c(u16 cmd, char *data, int size)
109diff --git a/debian/patches/backport-fix-build-against-kernels-v6.3.patch b/debian/patches/backport-fix-build-against-kernels-v6.3.patch
110new file mode 100644
111index 0000000..009da67
112--- /dev/null
113+++ b/debian/patches/backport-fix-build-against-kernels-v6.3.patch
114@@ -0,0 +1,28 @@
115+From: You-Sheng Yang <vicamo@gmail.com>
116+Date: Tue, 16 Dec 2025 21:02:44 +0800
117+Subject: backport: fix build against kernels < v6.3
118+
119+v6.3-rc2 commit 03c835f498b54 ("i2c: Switch .probe() to not take an id
120+parameter") removed the second id parameter.
121+
122+Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
123+---
124+ drivers/misc/icvs/intel_cvs.c | 4 ++++
125+ 1 file changed, 4 insertions(+)
126+
127+diff --git a/drivers/misc/icvs/intel_cvs.c b/drivers/misc/icvs/intel_cvs.c
128+index 0fb0420..4b6b8f0 100644
129+--- a/drivers/misc/icvs/intel_cvs.c
130++++ b/drivers/misc/icvs/intel_cvs.c
131+@@ -743,7 +743,11 @@ static struct i2c_driver cvs_i2c_driver = {
132+ .dev_groups = cvs_groups,
133+ .pm = pm_ptr(ICVS_DEV_PM_OPS),
134+ },
135++#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 3, 0)
136++ .probe_new = cvs_i2c_probe,
137++#else
138+ .probe = cvs_i2c_probe,
139++#endif
140+ .remove = cvs_i2c_remove
141+ };
142+
143diff --git a/debian/patches/dkms-specify-BUILD_EXCLUSIVE_KERNEL_MIN.patch b/debian/patches/dkms-specify-BUILD_EXCLUSIVE_KERNEL_MIN.patch
144new file mode 100644
145index 0000000..4b56af6
146--- /dev/null
147+++ b/debian/patches/dkms-specify-BUILD_EXCLUSIVE_KERNEL_MIN.patch
148@@ -0,0 +1,21 @@
149+From: You-Sheng Yang <vicamo@gmail.com>
150+Date: Tue, 16 Dec 2025 22:58:14 +0800
151+Subject: dkms: specify BUILD_EXCLUSIVE_KERNEL_MIN
152+
153+The implementation depends on SYSTEM_SLEEP_PM_OPS macro that was
154+introduced in v5.17-rc1.
155+
156+Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
157+---
158+ dkms.conf | 1 +
159+ 1 file changed, 1 insertion(+)
160+
161+diff --git a/dkms.conf b/dkms.conf
162+index 838f518..38de437 100644
163+--- a/dkms.conf
164++++ b/dkms.conf
165+@@ -9,3 +9,4 @@ DEST_MODULE_LOCATION[0]="/updates"
166+
167+ AUTOINSTALL="yes"
168+ BUILD_EXCLUSIVE_CONFIG="CONFIG_ACPI CONFIG_GPIOLIB CONFIG_I2C"
169++BUILD_EXCLUSIVE_KERNEL_MIN="5.17"
170diff --git a/debian/patches/series b/debian/patches/series
171index d12c740..f46ec61 100644
172--- a/debian/patches/series
173+++ b/debian/patches/series
174@@ -1,2 +1,6 @@
175 0001-dkms-use-debian-package-version-as-PACKAGE_VERSION.patch
176 0002-dkms-add-BUILD_EXCLUSIVE_CONFIG.patch
177+backport-fix-build-against-kernels-v6.11.patch
178+backport-fix-build-against-kernels-v6.3.patch
179+backport-fix-build-against-kernels-v6.1.patch
180+dkms-specify-BUILD_EXCLUSIVE_KERNEL_MIN.patch

Subscribers

People subscribed via source and target branches