Ubuntu
broadcom-sta package

~vicamo/ubuntu/+source/broadcom-sta:bug-2030978/ubsan/plucky

Git
lp:~vicamo/ubuntu/+source/broadcom-sta
bug-2030978/ubsan/plucky

Last commit made on 2025-08-18

Get this branch:: git clone -b bug-2030978/ubsan/plucky https://git.launchpad.net/~vicamo/ubuntu/+source/broadcom-sta

Only You-Sheng Yang can upload to this branch. If you are You-Sheng Yang please log in for upload directions.

Branch merges

Merged into ubuntu/+source/broadcom-sta:ubuntu/plucky-devel at revision c29e6fb21c505b7ea91877d312e87239308757b9

Vladimir Petko (community): Approve on 2025-10-03

Benjamin Drung (community): Needs Fixing on 2025-10-02

git-ubuntu import: Pending requested 2025-08-18

Branch information

Name:: bug-2030978/ubsan/plucky

Repository:: lp:~vicamo/ubuntu/+source/broadcom-sta

Recent commits

c29e6fb... by You-Sheng Yang on 2025-08-17

debian: bump version

d5e7be9... by =?utf-8?q?Joan_Bruguera_Mic=C3=B3?= <email address hidden> on 2023-08-05

Tentative patch for broadcom-wl 6.30.223.271 driver for Linux 6.5-rc1

BugLink: https://bugs.launchpad.net/bugs/2030978

Applies on top of all the patches applied to broadcom-wl-dkms 6.30.223.271-36 on Arch Linux

On Linux 6.5, due to commit 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS
on GCC"), flexible trailing arrays declared like `whatever_t foo[1];`
will generate warnings when CONFIG_UBSAN & co. is enabled, such as:

    UBSAN: array-index-out-of-bounds in /var/lib/dkms/broadcom-wl/6.30.223.271/build/amd64/src/wl/sys/wl_linux.c:1919:4
    index 2 is out of range for type 'ether_addr [1]'
    CPU: 8 PID: 131 Comm: kworker/8:1 Tainted: P OE [...]
    Hardware name: [...]
    Workqueue: ipv6_addrconf addrconf_dad_work
    Call Trace:
     <TASK>
     dump_stack_lvl+0x47/0x60
     __ubsan_handle_out_of_bounds+0xc7/0x100
     _wl_set_multicast_list+0x372/0x710 [wl b2d4dadbf09aee67f0822b96bf7f4b96338be49b]
     ? __dev_mc_add+0xb3/0x150
     [...]

This was technically always wrong, but was detected now because of the
commit above, and because Ubuntu 23.04 enables CONFIG_UBSAN by default.
Thanks to Satadru Pramanik for the heads-up & report.

Migrate them to the standard C99 syntax `whatever_t foo[];` to fix it.
(Quite a few trailing one-element arrays remain unchanged, either
because they are never used, or never accessed past the first element)

Reported-by: Satadru Pramanik <email address hidden>
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2d47c6956ab3c8b580a59d7704aab3e2a4882b6c
Link: https://lwn.net/Articles/936728/
Signed-off-by: You-Sheng Yang <email address hidden>