Merge ~vicamo/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:bug-1863583/obsolete-by-5.4/groovy into ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/groovy

Proposed by You-Sheng Yang
Status: Merged
Merged at revision: f3f6d1eb4d1d6827af452ed62d353ef0592acecd
Proposed branch: ~vicamo/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:bug-1863583/obsolete-by-5.4/groovy
Merge into: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/groovy
Diff against target: 60 lines (+9/-3)
4 files modified
debian/backport-iwlwifi-dkms.dkms.in (+1/-0)
debian/changelog (+7/-0)
debian/control (+0/-2)
debian/rules (+1/-1)
Reviewer Review Type Date Requested Status
You-Sheng Yang Approve
Review via email: mp+384019@code.launchpad.net

Description of the change

* dkms: add OBSOLETE_BY=5.4.0 (LP: #1863583)
* debian: drop modaliases support (LP: #1869587)

To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) wrote :
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

shouldn't it be removed from the archive instead?

Revision history for this message
You-Sheng Yang (vicamo) wrote :

Hi, Focal is a LTS like Bionic, and like Bionic we have to maintain it for years and we're almost certainly going to need it again some time later to support new hardware. Unless it's officially dead in the upstream, I would suggest we keep it for now.

Revision history for this message
You-Sheng Yang (vicamo) :
review: Approve
Revision history for this message
You-Sheng Yang (vicamo) wrote :

8324-0ubuntu2 is now in groovy with modaliases removed, so it won't be pulled automatically from additional drivers from now on.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/backport-iwlwifi-dkms.dkms.in b/debian/backport-iwlwifi-dkms.dkms.in
2index 285c400..48bc882 100644
3--- a/debian/backport-iwlwifi-dkms.dkms.in
4+++ b/debian/backport-iwlwifi-dkms.dkms.in
5@@ -1,6 +1,7 @@
6 PACKAGE_NAME="@DKMS_PACKAGE_NAME@"
7 PACKAGE_VERSION="#MODULE_VERSION#"
8 AUTOINSTALL="yes"
9+OBSOLETE_BY="5.4.0"
10
11 BUILT_MODULE_NAME[0]="compat"
12 BUILT_MODULE_LOCATION[0]="compat"
13diff --git a/debian/changelog b/debian/changelog
14index ab4bcc3..77179e1 100644
15--- a/debian/changelog
16+++ b/debian/changelog
17@@ -1,3 +1,10 @@
18+backport-iwlwifi-dkms (8324-0ubuntu2) groovy; urgency=medium
19+
20+ * dkms: add OBSOLETE_BY=5.4.0 (LP: #1863583)
21+ * debian: drop modaliases support (LP: #1869587)
22+
23+ -- You-Sheng Yang <vicamo@gmail.com> Fri, 15 May 2020 16:28:22 +0800
24+
25 backport-iwlwifi-dkms (8324-0ubuntu1) focal; urgency=low
26
27 * New release
28diff --git a/debian/control b/debian/control
29index b85c500..f909b74 100644
30--- a/debian/control
31+++ b/debian/control
32@@ -4,7 +4,6 @@ Priority: optional
33 Maintainer: You-Sheng Yang <vicamo@gmail.com>
34 Build-Depends:
35 debhelper (>=9),
36- dh-modaliases,
37 dkms,
38 quilt,
39 Standards-Version: 4.3.0
40@@ -19,7 +18,6 @@ Depends:
41 libc6-dev | libc-dev,
42 ${misc:Depends},
43 Provides: iwlwifi-modules
44-XB-Modaliases: ${modaliases}
45 Description: iwlwifi driver backport in DKMS format
46 Intel works with periodic releases of the iwlwifi driver that are
47 tested with a specific combination of components such as firmware and
48diff --git a/debian/rules b/debian/rules
49index 429ab0d..fa8049e 100755
50--- a/debian/rules
51+++ b/debian/rules
52@@ -10,7 +10,7 @@ GENERATED_DKMS_FILES= \
53 debian/backport-iwlwifi-dkms.dkms
54
55 %:
56- dh $@ --with dkms,modaliases
57+ dh $@ --with dkms
58
59 override_dh_auto_configure:
60 override_dh_auto_build:

Subscribers

People subscribed via source and target branches