Merge ~vicamo/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:bug-1856184/dont-include-linux-pci-aspm.h/focal into ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/focal

Proposed by You-Sheng Yang
Status: Merged
Merged at revision: 1f5d18cf4b45e4e06182a6ba26591aac635a81f6
Proposed branch: ~vicamo/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:bug-1856184/dont-include-linux-pci-aspm.h/focal
Merge into: ~canonical-hwe-team/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms:ubuntu/focal
Diff against target: 62 lines (+40/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/0007-backport-don-t-include-linux-pci-aspm.h-on-kernel-v5..patch (+32/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
You-Sheng Yang Approve
Review via email: mp+376753@code.launchpad.net
To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index f2c1e47..d4fd01b 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+backport-iwlwifi-dkms (8042-0ubuntu3) focal; urgency=medium
7+
8+ * debian/patches/0007-backport-don-t-include-linux-pci-aspm.h-on-kernel-v5..patch
9+ - Fix build on Focal v5.4 kernels. (LP: #1856184)
10+
11+ -- You-Sheng Yang <vicamo.yang@canonical.com> Fri, 13 Dec 2019 09:06:45 +0000
12+
13 backport-iwlwifi-dkms (8042-0ubuntu2) focal; urgency=critical
14
15 * debian/gbp.conf, debian/gitlab-ci.yml
16diff --git a/debian/patches/0007-backport-don-t-include-linux-pci-aspm.h-on-kernel-v5..patch b/debian/patches/0007-backport-don-t-include-linux-pci-aspm.h-on-kernel-v5..patch
17new file mode 100644
18index 0000000..ac6959a
19--- /dev/null
20+++ b/debian/patches/0007-backport-don-t-include-linux-pci-aspm.h-on-kernel-v5..patch
21@@ -0,0 +1,32 @@
22+From 7295f5fb6cc8394104a8ec39de1217048ed7a6e6 Mon Sep 17 00:00:00 2001
23+From: You-Sheng Yang <vicamo.yang@canonical.com>
24+Date: Fri, 13 Dec 2019 08:54:42 +0000
25+Subject: [PATCH] backport: don't include linux/pci-aspm.h on kernel >= v5.4-rc1
26+
27+linux/pci-aspm.h has been merged into linux/pci.h in commit 7ce2e76a0420
28+("PCI: Move ASPM declarations to linux/pci.h"), and mainline iwlwifi
29+removed such inclusion in commit 2b2654b8922a ("iwlwifi: Remove
30+unnecessary include of <linux/pci-aspm.h>").
31+
32+Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
33+---
34+ drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 ++
35+ 1 file changed, 2 insertions(+)
36+
37+diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
38+index 495ff9418..0fa34a93a 100644
39+--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
40++++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
41+@@ -62,7 +62,9 @@
42+ *
43+ *****************************************************************************/
44+ #include <linux/pci.h>
45++#if LINUX_VERSION_IS_LESS(5,4,0)
46+ #include <linux/pci-aspm.h>
47++#endif
48+ #include <linux/interrupt.h>
49+ #include <linux/debugfs.h>
50+ #include <linux/sched.h>
51+--
52+2.24.0
53+
54diff --git a/debian/patches/series b/debian/patches/series
55index 1c8cd90..9c971ba 100644
56--- a/debian/patches/series
57+++ b/debian/patches/series
58@@ -3,3 +3,4 @@
59 0003-backport-apply-__copy-to-init_module-cleanup_module.patch
60 0005-Makefile.kernel-pass-fno-stack-clash-protection-and-.patch
61 0006-backport-address-interface-change-in-linux-skbuff.h-.patch
62+0007-backport-don-t-include-linux-pci-aspm.h-on-kernel-v5..patch

Subscribers

People subscribed via source and target branches