Merge lp:~vicamo/qtmir/build-qtmir-android-arm64 into lp:qtmir

Proposed by You-Sheng Yang
Status: Merged
Approved by: Michał Sawicz
Approved revision: 550
Merged at revision: 553
Proposed branch: lp:~vicamo/qtmir/build-qtmir-android-arm64
Merge into: lp:qtmir
Diff against target: 24 lines (+2/-2)
2 files modified
debian/gles-patches/convert-to-gles.patch (+1/-1)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~vicamo/qtmir/build-qtmir-android-arm64
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Gerry Boland (community) Approve
Review via email: mp+303760@code.launchpad.net

Commit message

Build qtmir-android on arm64 for the need of valid libqpa-mirserver.so for ubuntu phone xenial arm64 porting.

Description of the change

Build qtmir-android on arm64 for the need of valid libqpa-mirserver.so for ubuntu phone xenial arm64 porting.

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Yep, good catch, thank you Vicamo!

review: Approve
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Hi, any thing I should do here?

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I'm getting during build's tests:

10/13 Test #1: convert-to-gles ..................***Failed 0.38 sec
+ dpkg-parsechangelog --show-field Source
+ [ qtmir = qtmir ]
+ QUILT_EXIT=0
+ export QUILT_PATCHES=debian/gles-patches
+ quilt push -a
Applying patch debian/gles-patches/convert-to-gles.patch
patching file debian/control
Hunk #2 succeeded at 17 with fuzz 1 (offset 1 line).
Hunk #3 succeeded at 38 (offset 1 line).
Hunk #4 succeeded at 52 (offset 1 line).
Hunk #5 succeeded at 63 (offset 1 line).
patching file debian/rules
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED -- rejects in file debian/rules
Patch debian/gles-patches/convert-to-gles.patch does not apply (enforce with -f)

So this would probably need adjusting of the convert-to-gles.patch too.

Revision history for this message
Michał Sawicz (saviq) wrote :

You need to apply this:

https://paste.ubuntu.com/23110948/

550. By You-Sheng Yang

Build qtmir-android on arm64.

Revision history for this message
Michał Sawicz (saviq) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/gles-patches/convert-to-gles.patch'
2--- debian/gles-patches/convert-to-gles.patch 2016-07-25 19:15:58 +0000
3+++ debian/gles-patches/convert-to-gles.patch 2016-08-30 09:45:22 +0000
4@@ -128,7 +128,7 @@
5 -
6 -# We only want to build qtmir-android on arches using Qt built with OpenGL ES2.0
7 -DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
8--gles2_architectures = armhf
9+-gles2_architectures = armhf arm64
10 -
11 -USES_GLES2 = $(findstring $(DEB_HOST_ARCH), $(gles2_architectures))
12
13
14=== modified file 'debian/rules'
15--- debian/rules 2016-02-17 13:27:50 +0000
16+++ debian/rules 2016-08-30 09:45:22 +0000
17@@ -12,7 +12,7 @@
18
19 # We only want to build qtmir-android on arches using Qt built with OpenGL ES2.0
20 DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
21-gles2_architectures = armhf
22+gles2_architectures = armhf arm64
23
24 USES_GLES2 = $(findstring $(DEB_HOST_ARCH), $(gles2_architectures))
25

Subscribers

People subscribed via source and target branches