This flag can be used by an end user to disable S0ix flows on a
buggy system or by an OEM for development purposes.
If you need this flag to be persisted across reboots, it's suggested
to use a udev rule to call adjust it until the kernel could have your
configuration in a disallow list.
Signed-off-by: Mario Limonciello <email address hidden>
Reviewed-by: Hans de Goede <email address hidden>
Tested-by: Yijun Shen <email address hidden>
Signed-off-by: Tony Nguyen <email address hidden>
(cherry picked from commit 3c98cbf22a96c1b12f48c1b2a4680dfe5cb280f9)
Signed-off-by: Aaron Ma <email address hidden>
Acked-by: Stefan Bader <email address hidden>
Acked-by: Kelsey Skunberg <email address hidden>
Signed-off-by: Kelsey Skunberg <email address hidden>
commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME
systems") disabled s0ix flows for systems that have various incarnations of
the i219-LM ethernet controller. This changed caused power consumption
regressions on the following shipping Dell Comet Lake based laptops:
* Latitude 5310
* Latitude 5410
* Latitude 5410
* Latitude 5510
* Precision 3550
* Latitude 5411
* Latitude 5511
* Precision 3551
* Precision 7550
* Precision 7750
This commit was introduced because of some regressions on certain Thinkpad
laptops. This comment was potentially caused by an earlier
commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable connected case").
or it was possibly caused by a system not meeting platform architectural
requirements for low power consumption. Other changes made in the driver
with extended timeouts are expected to make the driver more impervious to
platform firmware behavior.
Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
Reviewed-by: Alexander Duyck <email address hidden>
Signed-off-by: Mario Limonciello <email address hidden>
Reviewed-by: Hans de Goede <email address hidden>
Tested-by: Yijun Shen <email address hidden>
Signed-off-by: Tony Nguyen <email address hidden>
(cherry picked from commit 6cecf02e77ab9bf97e9252f9fcb8f0738a6de12c)
Signed-off-by: Aaron Ma <email address hidden>
Acked-by: Stefan Bader <email address hidden>
Acked-by: Kelsey Skunberg <email address hidden>
Signed-off-by: Kelsey Skunberg <email address hidden>
Per guidance from Intel ethernet architecture team, it may take
up to 1 second for unconfiguring ULP mode.
However in practice this seems to be taking up to 2 seconds on
some Lenovo machines. Detect scenarios that take more than 1 second
but less than 2.5 seconds and emit a warning on resume for those
scenarios.
Suggested-by: Aaron Ma <email address hidden>
Suggested-by: Sasha Netfin <email address hidden>
Suggested-by: Hans de Goede <email address hidden>
CC: Mark Pearson <email address hidden>
Fixes: f15bb6dde738cc8fa0 ("e1000e: Add support for S0ix")
BugLink: https://bugs.launchpad.net/bugs/1865570
Link: https://patchwork.ozlabs.org<email address hidden>/
Link: https://lkml.org/lkml/2020/12/13/15
Link: https://lkml.org/lkml/2020/12/14/708
Signed-off-by: Mario Limonciello <email address hidden>
Reviewed-by: Hans de Goede <email address hidden>
Tested-by: Yijun Shen <email address hidden>
Signed-off-by: Tony Nguyen <email address hidden>
(cherry picked from commit 3cf31b1a9effd859bb3d6ff9f8b5b0d5e6cac952)
Signed-off-by: Aaron Ma <email address hidden>
Acked-by: Stefan Bader <email address hidden>
Acked-by: Kelsey Skunberg <email address hidden>
Signed-off-by: Kelsey Skunberg <email address hidden>