After commit 6e02318eaea5 ("nvme: add support for the Write Zeroes
command"), SK hynix PC400 becomes very slow with the following error
message:
[ 224.567695] blk_update_request: operation not supported error, dev nvme1n1, sector 499384320 op 0x9:(WRITE_ZEROES) flags 0x1000000 phys_seg 0 prio class 0]
SK Hynix PC400 has a buggy firmware that treats NLB as max value instead
of a range, so the NLB passed isn't a valid value to the firmware.
According to SK hynix there are three commands are affected:
- Write Zeroes
- Compare
- Write Uncorrectable
Right now only Write Zeroes is implemented, so disable it completely on
SK hynix PC400.
Cc: kyounghwan sohn <email address hidden>
Signed-off-by: Kai-Heng Feng <email address hidden>
Signed-off-by: Christoph Hellwig <email address hidden>
(cherry picked from commit 5611ec2b9814bc91f7b0a8d804c1fc152e2025d9 nvme/nvme-5.8)
Signed-off-by: AceLan Kao <email address hidden>
Signed-off-by: Timo Aaltonen <email address hidden>
In order for no_refcnt and is_data to be the lowest order two
bits in the 'val' we have to pad out the bitfield of the u8.
Fixes: ad0f75e5f57c ("cgroup: fix cgroup_sk_alloc() for sk_clone_lock()")
Reported-by: Guenter Roeck <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
(cherry picked from commit 14b032b8f8fce03a546dcf365454bec8c4a58d7d)
Signed-off-by: Thadeu Lima de Souza Cascardo <email address hidden>
Signed-off-by: Timo Aaltonen <email address hidden>
When we clone a socket in sk_clone_lock(), its sk_cgrp_data is
copied, so the cgroup refcnt must be taken too. And, unlike the
sk_alloc() path, sock_update_netprioidx() is not called here.
Therefore, it is safe and necessary to grab the cgroup refcnt
even when cgroup_sk_alloc is disabled.
sk_clone_lock() is in BH context anyway, the in_interrupt()
would terminate this function if called there. And for sk_alloc()
skcd->val is always zero. So it's safe to factor out the code
to make it more readable.
The global variable 'cgroup_sk_alloc_disabled' is used to determine
whether to take these reference counts. It is impossible to make
the reference counting correct unless we save this bit of information
in skcd->val. So, add a new bit there to record whether the socket
has already taken the reference counts. This obviously relies on
kmalloc() to align cgroup pointers to at least 4 bytes,
ARCH_KMALLOC_MINALIGN is certainly larger than that.
This bug seems to be introduced since the beginning, commit
d979a39d7242 ("cgroup: duplicate cgroup reference when cloning sockets")
tried to fix it but not compeletely. It seems not easy to trigger until
the recent commit 090e28b229af
("netprio_cgroup: Fix unlimited memory leak of v2 cgroups") was merged.
Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")
Reported-by: Cameron Berkenpas <email address hidden>
Reported-by: Peter Geis <email address hidden>
Reported-by: Lu Fengqi <email address hidden>
Reported-by: Daniël Sonck <email address hidden>
Reported-by: Zhang Qiang <email address hidden>
Tested-by: Cameron Berkenpas <email address hidden>
Tested-by: Peter Geis <email address hidden>
Tested-by: Thomas Lamprecht <email address hidden>
Cc: Daniel Borkmann <email address hidden>
Cc: Zefan Li <email address hidden>
Cc: Tejun Heo <email address hidden>
Cc: Roman Gushchin <email address hidden>
Signed-off-by: Cong Wang <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
(cherry picked from commit ad0f75e5f57ccbceec13274e1e242f2b5a6397ed)
Signed-off-by: Thadeu Lima de Souza Cascardo <email address hidden>
Signed-off-by: Timo Aaltonen <email address hidden>
84ac467...
by
Dmitry Bogdanov <email address hidden>
This patch adds support for FW 4.x, which is about to get into the
production for some products.
4.x is mostly compatible with 3.x, save for soft reset, which requires
the acquisition of 2 additional semaphores.
Other differences (e.g. absence of PTP support) are handled via
capabilities.
Note: 4.x targets specific products only. 3.x is still the main firmware
branch, which should be used by most users (at least for now).
Signed-off-by: Dmitry Bogdanov <email address hidden>
Signed-off-by: Mark Starovoytov <email address hidden>
Signed-off-by: Igor Russkikh <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
(cherry picked from commit 0044b1e1470aa62eeabb24983e2ff5433a68666a linux-next)
Signed-off-by: Kai-Heng Feng <email address hidden>
Signed-off-by: Timo Aaltonen <email address hidden>
