Merge lp:~vibhavp/ubuntu/raring/spl/merge-from-debian into lp:ubuntu/raring/spl

Proposed by Vibhav Pant
Status: Merged
Merge reported by: Daniel T Chen
Merged at revision: not available
Proposed branch: lp:~vibhavp/ubuntu/raring/spl/merge-from-debian
Merge into: lp:ubuntu/raring/spl
Diff against target: 99 lines (+67/-1)
4 files modified
debian/changelog (+16/-0)
debian/control (+1/-1)
debian/patches/03_fix-hurd-ftbfs (+49/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~vibhavp/ubuntu/raring/spl/merge-from-debian
Reviewer Review Type Date Requested Status
Daniel T Chen Approve
Andrew Starr-Bochicchio (community) Needs Information
Ubuntu branches Pending
Review via email: mp+140953@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

What does this mean:

  - Prefer Debian's 02_fix-ld---as-needed-ftbfs, which means we need
    to reverse-apply it in the actual source so that the patch will
    apply upon `quilt push -a'.

Looking at the history, AFAICT this doesn't actually seem to be a remaining Ubuntu change, just a changelog entry that has been carried over for no real reason. Am I missing something?

review: Needs Information
Revision history for this message
Vibhav Pant (vibhavp) wrote :

Yes, I have added a wrong entry.

Revision history for this message
Daniel T Chen (crimsun) wrote :

Thanks. There was likely some cruft in my source directory when I first generated the source package in 2011. In any case, I've uploaded a tweaked version of this merge (added a missing versioned build-dep on dpkg-dev to pick up the multiarch var).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-07-26 12:27:29 +0000
3+++ debian/changelog 2013-03-26 11:11:29 +0000
4@@ -1,3 +1,19 @@
5+spl (1.0~pre6-4ubuntu1) raring; urgency=low
6+
7+ * Merge from Debian unstable. Remaining changes:
8+ + Add 03_ubuntu_multiarch:
9+ debian/rules: Use multiarch locations. Fixes FTBFS. (LP: #852606)
10+
11+ -- Vibhav Pant <vibhavp@ubuntu.com> Thu, 20 Dec 2012 22:47:49 +0530
12+
13+spl (1.0~pre6-4) unstable; urgency=low
14+
15+ * Add new patch fix-hurd-ftbfs provided by Svante Signell to fix FTBFS on
16+ hurd (closes: #686162)
17+ * Bump Standards-Version to 3.9.3.
18+
19+ -- Gerfried Fuchs <rhonda@debian.org> Fri, 07 Sep 2012 10:31:58 +0200
20+
21 spl (1.0~pre6-3.1ubuntu1) quantal; urgency=low
22
23 * Merge from Debian unstable. Remaining changes:
24
25=== modified file 'debian/control'
26--- debian/control 2012-07-26 12:27:29 +0000
27+++ debian/control 2013-03-26 11:11:29 +0000
28@@ -10,7 +10,7 @@
29 # libsmokeqt4-dev, libqt4-dev,
30 # qt3-dev-tools, libqt3-headers, libqt3-mt-dev,
31 Build-Conflicts: libsmokeqt4-dev
32-Standards-Version: 3.9.2
33+Standards-Version: 3.9.3
34 Homepage: http://www.clifford.at/spl/
35 Vcs-Browser: http://git.deb.at/w/pkg/spl.git
36 Vcs-Git: git://git.deb.at/g/pkg/spl.git
37
38=== added file 'debian/patches/03_fix-hurd-ftbfs'
39--- debian/patches/03_fix-hurd-ftbfs 1970-01-01 00:00:00 +0000
40+++ debian/patches/03_fix-hurd-ftbfs 2013-03-26 11:11:29 +0000
41@@ -0,0 +1,49 @@
42+Author: Svante Signell <svante.signell@telia.com> vim:ft=diff:
43+Description: Fix FTBFS issue for hurd-i386
44+Bug-Debian: http://bugs.debian.org/686162
45+
46+--- a/webspld.c
47++++ b/webspld.c
48+@@ -62,7 +62,11 @@
49+ static int pool_size = 32;
50+ static struct pool_entry *pool = 0;
51+
52++#if (_POSIX_VERSION >= 200809L)
53++static char *daemon_basedir = ".";
54++#else
55+ static char daemon_basedir[PATH_MAX] = ".";
56++#endif
57+
58+ struct code_cache {
59+ char *filename;
60+@@ -475,7 +479,7 @@
61+
62+ printf("\nConnection from %s:%u.\n",
63+ inet_ntoa(args->addr.sin_addr), ntohs(args->addr.sin_port));
64+-
65++
66+ PROFILE_INC(requests);
67+ handle_http_request(args->fd,
68+ webspld_vm_pool_get, webspld_vm_pool_put,
69+@@ -640,7 +644,11 @@
70+ struct sockaddr_in addr;
71+ struct linger sl = { 1, 5 };
72+
73++#if (_POSIX_VERSION >= 200809L)
74++ daemon_basedir = getcwd(NULL, 0);
75++#else
76+ getcwd(daemon_basedir, PATH_MAX);
77++#endif
78+
79+ printf("Loading SPL CGI module.\n");
80+ SPL_REGISTER_BUILTIN_MODULE(cgi);
81+@@ -708,6 +716,9 @@
82+ SPL_FREE_BUILTIN_MODULES();
83+ free(pool);
84+
85++#if (_POSIX_VERSION >= 200809L)
86++ free(daemon_basedir);
87++#endif
88+ if (code_cache_size) {
89+ for (int i=0; i<code_cache_size; i++)
90+ free_code_cache(code_cache_list + i);
91
92=== modified file 'debian/patches/series'
93--- debian/patches/series 2011-09-22 23:11:08 +0000
94+++ debian/patches/series 2013-03-26 11:11:29 +0000
95@@ -1,3 +1,4 @@
96 01_fix-kfreebsd-ftbfs
97 02_fix-ld---as-needed-ftbfs
98 03_ubuntu_multiarch
99+03_fix-hurd-ftbfs

Subscribers

People subscribed via source and target branches

to all changes: