Merge lp:~vibhavp/ubuntu/raring/libpipeline/add-atuopkgtest into lp:ubuntu/raring/libpipeline

Proposed by Vibhav Pant
Status: Merged
Approved by: Martin Pitt
Approved revision: 13
Merged at revision: 12
Proposed branch: lp:~vibhavp/ubuntu/raring/libpipeline/add-atuopkgtest
Merge into: lp:ubuntu/raring/libpipeline
Diff against target: 75 lines (+42/-1)
4 files modified
debian/changelog (+6/-0)
debian/control (+3/-1)
debian/tests/build (+31/-0)
debian/tests/control (+2/-0)
To merge this branch: bzr merge lp:~vibhavp/ubuntu/raring/libpipeline/add-atuopkgtest
Reviewer Review Type Date Requested Status
Colin Watson Approve
Martin Pitt Approve
Review via email: mp+154883@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

+# autopkgtest check: Build and run a program against glib, to verify that the

Please fix the name (copy&paste error). Can you please also add -Wall -Werror to spot more potential problems?

Thank you!

review: Needs Fixing
13. By Vibhav Pant

Correct typo. Add -Wall -Werror

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! Verified to work in a VM, too: run-adt-test -s -S lp:~vibhavp/ubuntu/raring/libpipeline/add-atuopkgtest libpipeline

I figure we don't want to merge this directly into Ubuntu, but Colin Watson would like to upload this to Debian instead and sync?

review: Approve
Revision history for this message
Colin Watson (cjwatson) wrote :

Indeed, thanks. I've merged this change into my Debian packaging branch (which doesn't share history with the normally-unused ubuntu:libpipeline branch, so I couldn't merge this directly) with a few tweaks, and am preparing an upload now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-09-17 23:33:15 +0000
3+++ debian/changelog 2013-03-22 08:28:22 +0000
4@@ -1,3 +1,9 @@
5+libpipeline (1.2.2-1ubuntu1) raring; urgency=low
6+
7+ * Add simple autopkgtest to package
8+
9+ -- Vibhav Pant <vibhavp@ubuntu.com> Fri, 22 Mar 2013 12:15:15 +0530
10+
11 libpipeline (1.2.2-1) unstable; urgency=low
12
13 * New upstream release.
14
15=== modified file 'debian/control'
16--- debian/control 2012-09-17 23:33:15 +0000
17+++ debian/control 2013-03-22 08:28:22 +0000
18@@ -1,9 +1,11 @@
19 Source: libpipeline
20 Section: libs
21 Priority: important
22-Maintainer: Colin Watson <cjwatson@debian.org>
23+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
24+XSBC-Original-Maintainer: Colin Watson <cjwatson@debian.org>
25 Standards-Version: 3.9.3
26 Build-Depends: dpkg-dev (>= 1.16.1~), debhelper (>= 8.9.0~), pkg-config, check
27+XS-Testsuite: autopkgtest
28 Homepage: http://libpipeline.nongnu.org/
29 Vcs-Bzr: http://anonscm.debian.org/bzr/users/cjwatson/libpipeline/trunk/
30
31
32=== added directory 'debian/tests'
33=== added file 'debian/tests/build'
34--- debian/tests/build 1970-01-01 00:00:00 +0000
35+++ debian/tests/build 2013-03-22 08:28:22 +0000
36@@ -0,0 +1,31 @@
37+#!/bin/sh
38+# autopkgtest check: Build and run a program against
39+# libpipeline, to verify that the headers and pkg-config file are
40+# installed correctly (C) 2013 Vibhav Pant Author: Vibhav Pant
41+# <vibhavp@ubuntu.com>
42+
43+set -e
44+
45+WORKDIR=$(mktemp -d)
46+trap "rm -rf $WORKDIR" 0 INT QUIT ABRT PIPE TERM
47+cd $WORKDIR
48+cat <<EOF > libpipeline_test.c
49+#include <pipeline.h>
50+#include <assert.h>
51+
52+int main()
53+{
54+ pipeline *p;
55+ p = pipeline_new();
56+ pipeline_command_args(p, "true", NULL);
57+ assert(pipeline_run(p) == 0);
58+ return 0;
59+}
60+
61+EOF
62+
63+gcc -o libpipeline_test libpipeline_test.c `pkg-config --cflags --libs libpipeline` -Wall -Werror
64+echo "build: OK"
65+[ -x libpipeline_test ]
66+./libpipeline_test
67+echo "run: OK"
68
69=== added file 'debian/tests/control'
70--- debian/tests/control 1970-01-01 00:00:00 +0000
71+++ debian/tests/control 2013-03-22 08:28:22 +0000
72@@ -0,0 +1,2 @@
73+Tests: build
74+Depends: libpipeline-dev, build-essential, pkg-config
75\ No newline at end of file

Subscribers

People subscribed via source and target branches

to all changes: