Merge lp:~vibhavp/ubuntu/raring/guile-2.0/gnulib-gets into lp:ubuntu/raring/guile-2.0

Proposed by Vibhav Pant
Status: Work in progress
Proposed branch: lp:~vibhavp/ubuntu/raring/guile-2.0/gnulib-gets
Merge into: lp:ubuntu/raring/guile-2.0
Diff against target: 82 lines (+21/-2) (has conflicts)
5 files modified
.pc/applied-patches (+1/-0)
debian/changelog (+9/-0)
debian/control (+2/-1)
debian/patches/series (+1/-0)
lib/stdio.in.h (+8/-1)
Text conflict in debian/changelog
Text conflict in lib/stdio.in.h
To merge this branch: bzr merge lp:~vibhavp/ubuntu/raring/guile-2.0/gnulib-gets
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Disapprove
Ubuntu branches Pending
Review via email: mp+151342@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Hartwig (wigs) wrote :

This patch is no longer needed since it is included in upstream 2.0.7 recently uploaded to raring.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Not needed any more.

review: Disapprove

Unmerged revisions

8. By Vibhav Pant

Avoid assuming that gets is declared. Fixes FTBFS.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.pc/applied-patches'
2--- .pc/applied-patches 2013-02-27 11:52:16 +0000
3+++ .pc/applied-patches 2013-03-02 03:48:22 +0000
4@@ -1,2 +1,3 @@
5 0001-Change-guile-to-guile-X.Y-for-info-pages.patch
6 0003-Mark-mutex-with-owner-not-retained-threads-test-as-u.patch
7+gnulib-gets
8
9=== modified file 'debian/changelog'
10--- debian/changelog 2013-02-28 07:53:18 +0000
11+++ debian/changelog 2013-03-02 03:48:22 +0000
12@@ -1,3 +1,4 @@
13+<<<<<<< TREE
14 guile-2.0 (2.0.7-0ubuntu2) raring; urgency=low
15
16 * Don't append the package version to the upstream version, breaking
17@@ -12,6 +13,14 @@
18
19 -- Matthias Klose <doko@ubuntu.com> Wed, 27 Feb 2013 11:52:16 +0100
20
21+=======
22+guile-2.0 (2.0.5+1-3ubuntu1) raring; urgency=low
23+
24+ * Avoid assuming that gets is declared. Fixes FTBFS.
25+
26+ -- Vibhav Pant <vibhavp@ubuntu.com> Thu, 28 Feb 2013 11:18:44 +0530
27+
28+>>>>>>> MERGE-SOURCE
29 guile-2.0 (2.0.5+1-3) unstable; urgency=low
30
31 * Add 0003-Mark-mutex-with-owner-not-retained-threads-test-as-u.patch.
32
33=== modified file 'debian/control'
34--- debian/control 2012-01-29 15:03:18 +0000
35+++ debian/control 2013-03-02 03:48:22 +0000
36@@ -1,7 +1,8 @@
37 Source: guile-2.0
38 Section: interpreters
39 Priority: optional
40-Maintainer: Rob Browning <rlb@defaultvalue.org>
41+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
42+XSBC-Original-Maintainer: Rob Browning <rlb@defaultvalue.org>
43 Build-Depends: libtool, debhelper (>= 8), autoconf, automake, dh-autoreconf,
44 libncurses5-dev, libreadline6-dev, libltdl-dev, libgmp-dev, texinfo, flex, libunistring-dev, libgc-dev, libffi-dev, pkg-config
45 Standards-Version: 3.7.2
46
47=== modified file 'debian/patches/series'
48--- debian/patches/series 2013-02-27 11:52:16 +0000
49+++ debian/patches/series 2013-03-02 03:48:22 +0000
50@@ -1,3 +1,4 @@
51 0001-Change-guile-to-guile-X.Y-for-info-pages.patch
52 #0002-Mark-Unused-modules-are-removed-gc-test-as-unresolve.patch
53 0003-Mark-mutex-with-owner-not-retained-threads-test-as-u.patch
54+0004-gnulib-gets.patch
55
56=== modified file 'lib/stdio.in.h'
57--- lib/stdio.in.h 2013-02-27 11:52:16 +0000
58+++ lib/stdio.in.h 2013-03-02 03:48:22 +0000
59@@ -700,13 +700,20 @@
60 #endif
61
62 /* It is very rare that the developer ever has full control of stdin,
63+<<<<<<< TREE
64 so any use of gets warrants an unconditional warning; besides, C11
65 removed it. */
66 #undef gets
67 #if HAVE_RAW_DECL_GETS
68+=======
69+ so any use of it warrants an unconditional warning; besides C11 had
70+ deprecated gets.
71+ */
72+#if HAVE_RAW_DECL_GETS
73+>>>>>>> MERGE-SOURCE
74 _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
75 #endif
76-
77+#endif
78
79 #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@
80 struct obstack;
81
82=== modified file 'm4/stdio_h.m4'

Subscribers

People subscribed via source and target branches

to all changes: