Merge lp:~vhata/ibid/conflate-config into lp:~ibid-core/ibid/old-trunk-1.6

Proposed by Jonathan Hitchcock
Status: Merged
Approved by: Jonathan Hitchcock
Approved revision: not available
Merged at revision: 819
Proposed branch: lp:~vhata/ibid/conflate-config
Merge into: lp:~ibid-core/ibid/old-trunk-1.6
Diff against target: 44 lines (+5/-4)
3 files modified
ibid/plugins/core.py (+3/-1)
ibid/source/irc.py (+1/-1)
ibid/source/silc.py (+1/-2)
To merge this branch: bzr merge lp:~vhata/ibid/conflate-config
Reviewer Review Type Date Requested Status
Stefano Rivera Approve
Michael Gorven Approve
Review via email: mp+16731@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Hitchcock (vhata) wrote :

There seems to be some angst about what to call the 'conflate' parameter now. Will check when I get back...

Revision history for this message
Michael Gorven (mgorven) wrote :

 review approve

review: Approve
Revision history for this message
Stefano Rivera (stefanor) wrote :

Fair enough

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/plugins/core.py'
2--- ibid/plugins/core.py 2009-12-30 22:18:47 +0000
3+++ ibid/plugins/core.py 2010-01-02 12:28:15 +0000
4@@ -186,10 +186,12 @@
5 for line in response['reply'].split('\n'):
6 r = {'reply': line}
7 for k in response.iterkeys():
8- if k not in ('reply', 'conflate'):
9+ if k not in ('reply'):
10 r[k] = response[k]
11 filtered.append(r)
12 else:
13+ if 'multiline' not in supports:
14+ response['reply'] = response['reply'].expandtabs(1).replace('\n', conflate == True and u' ' or conflate or u'')
15 filtered.append(response)
16
17 event.responses = filtered
18
19=== modified file 'ibid/source/irc.py'
20--- ibid/source/irc.py 2009-12-30 22:18:47 +0000
21+++ ibid/source/irc.py 2010-01-02 12:28:15 +0000
22@@ -167,7 +167,7 @@
23 self.send(response)
24
25 def send(self, response):
26- message = response['reply'].expandtabs(1).replace('\n', ' ')[:490]
27+ message = response['reply']
28 raw_message = message.encode('utf-8')
29
30 # Target may be a connection or a plain nick
31
32=== modified file 'ibid/source/silc.py'
33--- ibid/source/silc.py 2009-12-30 22:18:47 +0000
34+++ ibid/source/silc.py 2010-01-02 12:28:15 +0000
35@@ -69,8 +69,7 @@
36 self.send(response)
37
38 def send(self, response):
39- message = response['reply'].expandtabs(1).replace('\n', ' ') \
40- .encode('utf-8')
41+ message = response['reply'].encode('utf-8')
42 flags=0
43 if response.get('action', False):
44 flags=4

Subscribers

People subscribed via source and target branches