Merge lp:~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 183
Merged at revision: 185
Proposed branch: lp:~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 60 lines (+15/-0)
3 files modified
src/app/qml/AuthenticationService.qml (+5/-0)
src/app/qml/TerminalPage.qml (+9/-0)
src/app/qml/ubuntu-terminal-app.qml (+1/-0)
To merge this branch: bzr merge lp:~verzegnassi-stefano/ubuntu-terminal-app/hide-terminal-data-on-auth
Reviewer Review Type Date Requested Status
Evan McIntire Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+288040@code.launchpad.net

Commit message

Hide terminal data until the access is granted (using a FastBlur).

Description of the change

Hide terminal data until the access is granted (using a FastBlur).

Screenshot (with 'top' command):
https://drive.google.com/open?id=0By4kAplbFcE6ek5XT2FiMXM2eWs

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Evan McIntire (mcintire-evan) wrote :

Tested, LGTM :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/AuthenticationService.qml'
2--- src/app/qml/AuthenticationService.qml 2016-01-09 01:47:56 +0000
3+++ src/app/qml/AuthenticationService.qml 2016-03-03 23:14:57 +0000
4@@ -26,6 +26,9 @@
5 Item {
6 id: authenticationService
7
8+ property var __authDialog
9+ readonly property bool isDialogVisible: __authDialog != null
10+
11 signal granted()
12 signal denied()
13
14@@ -63,6 +66,8 @@
15
16 authentication_dialog.passwordEntered.connect( verify_password );
17 authentication_dialog.dialogCanceled.connect( denied );
18+
19+ __authDialog = authentication_dialog
20 }
21
22 PamAuthentication {
23
24=== modified file 'src/app/qml/TerminalPage.qml'
25--- src/app/qml/TerminalPage.qml 2016-01-22 18:01:49 +0000
26+++ src/app/qml/TerminalPage.qml 2016-03-03 23:14:57 +0000
27@@ -3,6 +3,9 @@
28 import Ubuntu.Components.Popups 1.3
29 import QMLTermWidget 1.0
30
31+// For FastBlur
32+import QtGraphicalEffects 1.0
33+
34 Page {
35 id: terminalPage
36 property alias terminalContainer: terminalContainer
37@@ -29,6 +32,12 @@
38 right: parent.right;
39 bottom: keyboardBarLoader.top
40 }
41+
42+ // Hide terminal data when the access is still not granted
43+ layer.enabled: authService.isDialogVisible
44+ layer.effect: FastBlur {
45+ radius: units.gu(6)
46+ }
47 }
48
49
50
51=== modified file 'src/app/qml/ubuntu-terminal-app.qml'
52--- src/app/qml/ubuntu-terminal-app.qml 2016-02-07 18:24:56 +0000
53+++ src/app/qml/ubuntu-terminal-app.qml 2016-03-03 23:14:57 +0000
54@@ -16,6 +16,7 @@
55 height: units.gu(55)
56
57 AuthenticationService {
58+ id: authService
59 onDenied: Qt.quit();
60 }
61

Subscribers

People subscribed via source and target branches