Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-update-sdcard-icon into lp:ubuntu-docviewer-app

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Roman Shchekin
Approved revision: 172
Merged at revision: 174
Proposed branch: lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-update-sdcard-icon
Merge into: lp:ubuntu-docviewer-app
Diff against target: 39 lines (+3/-2)
3 files modified
debian/control (+1/-0)
src/app/qml/documentPage/DocumentGridDelegate.qml (+1/-1)
src/app/qml/documentPage/DocumentListDelegate.qml (+1/-1)
To merge this branch: bzr merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-update-sdcard-icon
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Document Viewer Developers Pending
Review via email: mp+270532@code.launchpad.net

Commit message

Use SD card icon from official Suru theme

Description of the change

Use SD card icon from official Suru theme

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
172. By Stefano Verzegnassi

Merged trunk - fixed conflict

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-02-23 12:49:52 +0000
3+++ debian/control 2015-09-09 14:06:14 +0000
4@@ -28,6 +28,7 @@
5 Architecture: any
6 Depends: qtdeclarative5-qtquick2-plugin,
7 qtdeclarative5-ubuntu-ui-toolkit-plugin,
8+ suru-icon-theme (>= 14.04+15.10.20150707-0ubuntu1),
9 ${misc:Depends}
10 Description: Document Viewer application
11 Core Document Viewer application
12
13=== removed file 'src/app/graphics/sd-card-symbolic.png'
14Binary files src/app/graphics/sd-card-symbolic.png 2015-05-13 14:22:36 +0000 and src/app/graphics/sd-card-symbolic.png 1970-01-01 00:00:00 +0000 differ
15=== modified file 'src/app/qml/documentPage/DocumentGridDelegate.qml'
16--- src/app/qml/documentPage/DocumentGridDelegate.qml 2015-08-04 16:01:37 +0000
17+++ src/app/qml/documentPage/DocumentGridDelegate.qml 2015-09-09 14:06:14 +0000
18@@ -65,7 +65,7 @@
19 }
20
21 visible: model.isFromExternalStorage
22- source: Qt.resolvedUrl("../../graphics/sd-card-symbolic.png")
23+ name: "sdcard-symbolic"
24 }
25
26 // Document mimetype icon
27
28=== modified file 'src/app/qml/documentPage/DocumentListDelegate.qml'
29--- src/app/qml/documentPage/DocumentListDelegate.qml 2015-08-04 16:01:37 +0000
30+++ src/app/qml/documentPage/DocumentListDelegate.qml 2015-09-09 14:06:14 +0000
31@@ -124,7 +124,7 @@
32
33 Icon {
34 anchors.fill: parent
35- source: Qt.resolvedUrl("../../graphics/sd-card-symbolic.png")
36+ name: "sdcard-symbolic"
37 }
38 }
39 }

Subscribers

People subscribed via source and target branches