Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 261
Merged at revision: 271
Proposed branch: lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml
Merge into: lp:ubuntu-docviewer-app
Diff against target: 11 lines (+1/-0)
1 file modified
debian/control (+1/-0)
To merge this branch: bzr merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+282674@code.launchpad.net

Commit message

added python3-lxml package as dependency

Description of the change

added python3-lxml package as dependency

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

LGTM

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

It does not fix anything.
I had a look at the clock-app, which has the same pyhton3-lxml dependency. Everything works well there.

Besides fixing debian/control, is there something else we'd need to fix?

Since our tests are definitely broken, or out of scope, or mostly not useful (i.e. "open a file from cmd and ensure that a UITK Page is visible"), could we disable Autopilot tests on our Jenkins configuration?

I guess we'd need to make all these MPs landing in a really short time, since you need/want the PDF presentation mode to be merged ASAP, and we have to complete the tasks for the OTA-9 (and we're getting a huge delay because of this)

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/39/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1446/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Retrying. I believe we solved this issue last week. If not we can disable it fix things so it doesn't block

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-11-27 16:39:21 +0000
3+++ debian/control 2016-01-14 21:34:15 +0000
4@@ -71,6 +71,7 @@
5 Architecture: all
6 Depends: libautopilot-qt,
7 libqt5test5,
8+ python3-lxml,
9 ubuntu-docviewer-app (>= ${source:Version}),
10 ubuntu-ui-toolkit-autopilot,
11 ${misc:Depends}

Subscribers

People subscribed via source and target branches