Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader into lp:ubuntu-docviewer-app
Status: | Merged |
---|---|
Approved by: | Stefano Verzegnassi |
Approved revision: | 260 |
Merged at revision: | 263 |
Proposed branch: | lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader |
Merge into: | lp:ubuntu-docviewer-app |
Diff against target: |
25 lines (+5/-5) 1 file modified
src/app/qml/common/NightModeShader.qml (+5/-5) |
To merge this branch: | bzr merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jenkins Bot | continuous-integration | Approve | |
Alan Pope πΊπ§π± π¦ (community) | Approve | ||
Review via email: mp+282041@code.launchpad.net |
Commit message
Night shader updated
Description of the change
Night shader updated
Some screenshot: https:/
(left: old shader - right: new one)
List of changes:
* Use a standard greyscale formula (from NTSC and PAL specs)
The difference is not visible though, but the previous values were only found in Qt examples (therefore not standard).
* Colors in the [0...255] range are now compressed into a [26...230] range.
* Colors between [204 and 230] are clipped to 204.
Recently I've tested the night mode with no ambient light.
Even if the amount of white is sensibly reduced by inverting the colors, I found the pure black (RGB 0,0,0) too bright.
Also, I found annoying to scroll a document with images, since the amount of white (or anyway light colors) was a bit high on average. With a further clipping of light tones, reading a document seems to be less tiring.
FAILED: Continuous integration, rev:260 /core-apps- jenkins. ubuntu. com/job/ run-ap- tests-ci/ 75/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/341/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ run-ap- tests-ci/ 75/rebuild
https:/