Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fullscreen-support into lp:ubuntu-docviewer-app/trunk
Proposed by
Stefano Verzegnassi
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alan Pope πΊπ§π± π¦ | ||||
Approved revision: | 117 | ||||
Merged at revision: | 118 | ||||
Proposed branch: | lp:~verzegnassi-stefano/ubuntu-docviewer-app/fullscreen-support | ||||
Merge into: | lp:ubuntu-docviewer-app/trunk | ||||
Prerequisite: | lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-toc-improvements | ||||
Diff against target: |
268 lines (+86/-9) 8 files modified
po/com.ubuntu.docviewer.pot (+3/-3) src/app/command-line-parser.cpp (+5/-0) src/app/command-line-parser.h (+2/-0) src/app/docviewer-application.cpp (+47/-1) src/app/docviewer-application.h (+6/-0) src/app/qml/pdfView/PdfContentsPage.qml (+1/-2) src/app/qml/pdfView/PdfView.qml (+3/-3) src/app/qml/ubuntu-docviewer-app.qml (+19/-0) |
||||
To merge this branch: | bzr merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fullscreen-support | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alan Pope πΊπ§π± π¦ (community) | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Stefano Verzegnassi | Pending | ||
Review via email:
|
Commit message
Open a document in fullscreen mode on devices
Description of the change
Open a document in fullscreen mode on devices
Code added here comes from lp:gallery-app
This MP depends on lp:~verzegnassi-stefano/ubuntu-docviewer-app/pdf-toc-improvements, since that branch introduces some fix for the invisible header in PdfContentsPage.
To post a comment you must log in.
PASSED: Continuous integration, rev:117 91.189. 93.70:8080/ job/ubuntu- docviewer- app-ci/ 192/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2551 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2551/artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/ubuntu- docviewer- app-utopic- amd64-ci/ 89 91.189. 93.70:8080/ job/ubuntu- docviewer- app-vivid- amd64-ci/ 95
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- docviewer- app-ci/ 192/rebuild
http://