Ubuntu Document Viewer App

Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into lp:ubuntu-docviewer-app

  1. fix-1566903
  2. Merge into lo-viewer
Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 331
Merged at revision: 335
Proposed branch: lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903
Merge into: lp:ubuntu-docviewer-app
Diff against target: 11 lines (+1/-0)
1 file modified
src/app/qml/documentPage/SharePage.qml (+1/-0)
To merge this branch: bzr merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Nekhelesh Ramananthan (community) code Approve
Ubuntu Document Viewer Developers Pending
Review via email: mp+291142@code.launchpad.net

Commit message

Fixed wrong alignment of the peer picker in SharePage.

Description of the change

Fixed wrong alignment of the peer picker in SharePage.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:331
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/272/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/854/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/272/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

LGTM!

review: Approve (code)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-autolanding/173/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5725/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:331
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/276/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/866/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/276/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/documentPage/SharePage.qml'
2--- src/app/qml/documentPage/SharePage.qml 2016-03-03 13:17:53 +0000
3+++ src/app/qml/documentPage/SharePage.qml 2016-04-06 16:29:43 +0000
4@@ -30,6 +30,7 @@
5
6 ContentPeerPicker {
7 id: picker
8+ anchors.topMargin: sharePage.header.height
9
10 contentType: ContentType.Documents
11 handler: ContentHandler.Share

Subscribers

People subscribed via source and target branches