Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523112 into lp:ubuntu-docviewer-app

[Stefano Verzegnassi]

Added Flickable in DetailsPage. Content can be scrolled when bigger than the page.

Added Flickable in DetailsPage. Content can be scrolled when bigger than the page.

[Jenkins Bot (ubuntu-core-apps-jenkins-bot)]

PASSED: Continuous integration, rev:242
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/56/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/279/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/56/rebuild

review: Approve (continuous-integration)

[Roman Shchekin (mrqtros)]

The using of ListView can be better solution, but for now it is ok.

review: Approve

=== modified file 'src/app/qml/common/DetailsPage.qml'
--- src/app/qml/common/DetailsPage.qml	2015-10-23 10:46:24 +0000
+++ src/app/qml/common/DetailsPage.qml	2015-12-26 18:46:12 +0000
@@ -24,39 +24,47 @@
     objectName: "detailsPage"
     title: i18n.tr("Details")
 
-    Column {
-        width: Math.min(units.gu(80), parent.width)
-        anchors {
-            top: parent.top
-            bottom: parent.bottom
-            horizontalCenter: parent.horizontalCenter
-        }
-
-        SubtitledListItem {
-            text: i18n.tr("Location")
-            subText: file.path
-        }
-
-        SubtitledListItem {
-            text: i18n.tr("Size")
-            subText: Utils.printSize(i18n, file.info.size)
-        }
-
-        SubtitledListItem {
-            text: i18n.tr("Created")
-            subText: file.info.creationTime.toLocaleString(Qt.locale())
-        }
-
-        SubtitledListItem {
-            text: i18n.tr("Last modified")
-            subText: file.info.lastModified.toLocaleString(Qt.locale())
-        }
-
-        SubtitledListItem {
-            // Used by Autopilot tests
-            objectName: "mimetypeItem"
-            text: i18n.tr("MIME type")
-            subText: file.mimetype.name
+    Flickable {
+        id: flick
+        anchors.fill: parent
+        interactive: true
+
+        contentWidth: parent.width
+        contentHeight: layout.height
+
+        Column {
+            id: layout
+            width: Math.min(units.gu(80), parent.width)
+            anchors.horizontalCenter: parent.horizontalCenter
+
+            SubtitledListItem {
+                text: i18n.tr("Location")
+                subText: file.path
+            }
+
+            SubtitledListItem {
+                text: i18n.tr("Size")
+                subText: Utils.printSize(i18n, file.info.size)
+            }
+
+            SubtitledListItem {
+                text: i18n.tr("Created")
+                subText: file.info.creationTime.toLocaleString(Qt.locale())
+            }
+
+            SubtitledListItem {
+                text: i18n.tr("Last modified")
+                subText: file.info.lastModified.toLocaleString(Qt.locale())
+            }
+
+            SubtitledListItem {
+                // Used by Autopilot tests
+                objectName: "mimetypeItem"
+                text: i18n.tr("MIME type")
+                subText: file.mimetype.name
+            }
         }
     }
+
+    Scrollbar { flickableItem: flick }
 }