Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1428248 into lp:ubuntu-docviewer-app/trunk

Proposed by Stefano Verzegnassi on 2015-03-04
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„ on 2015-03-04
Approved revision: 93
Merged at revision: 91
Proposed branch: lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1428248
Merge into: lp:ubuntu-docviewer-app/trunk
Diff against target: 100 lines (+31/-26)
2 files modified
po/com.ubuntu.docviewer.pot (+1/-1)
src/app/qml/documentPage/DocumentGridDelegate.qml (+30/-25)
To merge this branch: bzr merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1428248
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ 2015-03-04 Approve on 2015-03-04
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-03-04
Review via email: mp+251811@code.launchpad.net

Commit Message

[DocumentGridDelegate] Moved file size label on a 3rd line.

Description of the Change

[DocumentGridDelegate] Moved file size label on a 3rd line.

To post a comment you must log in.
92. By Stefano Verzegnassi on 2015-03-04

[DocumentGridDelegate] Fixed alignment of text

93. By Stefano Verzegnassi on 2015-03-04

Merge with trunk

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/com.ubuntu.docviewer.pot'
2--- po/com.ubuntu.docviewer.pot 2015-03-04 17:48:47 +0000
3+++ po/com.ubuntu.docviewer.pot 2015-03-04 19:38:59 +0000
4@@ -8,7 +8,7 @@
5 msgstr ""
6 "Project-Id-Version: \n"
7 "Report-Msgid-Bugs-To: \n"
8-"POT-Creation-Date: 2015-03-04 18:46+0100\n"
9+"POT-Creation-Date: 2015-03-04 20:36+0100\n"
10 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
11 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
12 "Language-Team: LANGUAGE <LL@li.org>\n"
13
14=== modified file 'src/app/qml/documentPage/DocumentGridDelegate.qml'
15--- src/app/qml/documentPage/DocumentGridDelegate.qml 2015-03-04 17:44:36 +0000
16+++ src/app/qml/documentPage/DocumentGridDelegate.qml 2015-03-04 19:38:59 +0000
17@@ -77,7 +77,7 @@
18 // Document mimetype icon
19 Icon {
20 anchors.centerIn: parent
21- anchors.verticalCenterOffset: - units.gu(2)
22+ anchors.verticalCenterOffset: - infoColumn.height * 0.3
23
24 width: units.gu(8); height: width
25
26@@ -127,45 +127,50 @@
27 bottom: parent.bottom
28 }
29
30- height: units.gu(6)
31+ height: infoColumn.height + units.gu(1)
32
33 color: UbuntuColors.darkGrey
34 opacity: 0.75
35- }
36-
37- // Document info
38- Column {
39- anchors { fill: overlay; margins: units.gu(0.5) }
40-
41- Label {
42- text: model.name
43- color: "white"
44-
45- elide: Text.ElideRight
46- font.weight: Font.DemiBold
47- fontSize: "small"
48-
49- anchors { left: parent.left; right: parent.right }
50- }
51-
52- RowLayout {
53- anchors { left: parent.left; right: parent.right }
54+ layer.enabled: true
55+
56+ // Document info
57+ Column {
58+ id: infoColumn
59+ anchors {
60+ left: parent.left;
61+ right: parent.right
62+ verticalCenter: parent.verticalCenter
63+ margins: units.gu(0.5)
64+ }
65+
66+ Label {
67+ text: model.name
68+ color: "white"
69+
70+ elide: Text.ElideRight
71+ font.weight: Font.DemiBold
72+ fontSize: "small"
73+
74+ anchors { left: parent.left; right: parent.right }
75+ }
76
77 Label {
78 text: formattedDateTime()
79- color: "white"
80+ color: "white"
81 fontSize: "small"
82
83- Layout.fillWidth: true
84+ anchors { left: parent.left; right: parent.right }
85 }
86
87 Label {
88 text: Utils.printSize(i18n, model.size)
89 color: "white"
90 fontSize: "small"
91+
92+ anchors { left: parent.left; right: parent.right }
93 }
94- }
95- } // Document info end
96+ } // Document info end
97+ }
98
99 states: [
100 State {

Subscribers

People subscribed via source and target branches