Merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-imported-folder into lp:ubuntu-docviewer-app

Proposed by Stefano Verzegnassi on 2016-04-14
Status: Needs review
Proposed branch: lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-imported-folder
Merge into: lp:ubuntu-docviewer-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/plugin/file-qml-plugin/docviewerutils.cpp (+1/-1)
To merge this branch: bzr merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-imported-folder
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ 2016-04-14 Needs Fixing on 2016-05-07
Jenkins Bot continuous-integration Approve on 2016-04-14
Review via email: mp+291923@code.launchpad.net

Commit message

Save imported files from content-hub in a separate folder.

Description of the change

Save imported files from content-hub in a separate folder.

To post a comment you must log in.
review: Approve (continuous-integration)

This doesn't work as expected.

Downloaded PDF from browser. Tap Open when done, get an error on Docviewer, and the file isn't saved. (no new files in ~/Documents on device)

Here's a video showing it.

https://youtu.be/R30dq-NeGe0

review: Needs Fixing

That happens also with the release currently available on the store (i.e. does not depend on this MP). If docviewer is already launched, everything works as expected.

In the log is there anything about Libertine containers? I started to see this problem when content-hub has added the support for xmir apps.
It happens only with docviewer though, I'll have a look (I suspect the QML Loader[1] causes the issue).

[1] http://bazaar.launchpad.net/~ubuntu-docviewer-dev/ubuntu-docviewer-app/lo-viewer/view/head:/src/app/qml/ubuntu-docviewer-app.qml#L208

Unmerged revisions

334. By Stefano Verzegnassi on 2016-04-14

Save imported files from content-hub in a separate folder.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/plugin/file-qml-plugin/docviewerutils.cpp'
2--- src/plugin/file-qml-plugin/docviewerutils.cpp 2015-12-27 12:10:06 +0000
3+++ src/plugin/file-qml-plugin/docviewerutils.cpp 2016-04-14 17:29:33 +0000
4@@ -91,7 +91,7 @@
5 if (suffix.isEmpty())
6 suffix = mt.preferredSuffix();
7
8- QString dir = QStandardPaths::writableLocation(QStandardPaths::DocumentsLocation) + QDir::separator();
9+ QString dir = QStandardPaths::writableLocation(QStandardPaths::DocumentsLocation) + QDir::separator() + "Imported" + QDir::separator();
10 QString destination = QString("%1.%2").arg(dir + filenameWithoutSuffix, suffix);
11
12 // If there's already a file of this name, reformat it to

Subscribers

People subscribed via source and target branches