Merge lp:~verzegnassi-stefano/quick-memo/fix-1411614 into lp:quick-memo/trunk

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 59
Merged at revision: 59
Proposed branch: lp:~verzegnassi-stefano/quick-memo/fix-1411614
Merge into: lp:quick-memo/trunk
Diff against target: 208 lines (+46/-47)
2 files modified
app/components/EditMemoPage.qml (+28/-29)
po/quick-memo.pot (+18/-18)
To merge this branch: bzr merge lp:~verzegnassi-stefano/quick-memo/fix-1411614
Reviewer Review Type Date Requested Status
Stefano Verzegnassi Pending
Review via email: mp+246831@code.launchpad.net

Commit message

Fix bug #1411614: Input lost after deleting memo

Description of the change

Fix bug #1411614: Input lost after deleting memo

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/components/EditMemoPage.qml'
2--- app/components/EditMemoPage.qml 2014-11-03 00:21:23 +0000
3+++ app/components/EditMemoPage.qml 2015-01-17 19:46:33 +0000
4@@ -122,7 +122,8 @@
5
6 onTriggered: {
7 if (!canSave) { // Change timer inteval if can't save?
8- PopupUtils.open(deleteDialog, memoPage, {emptyMemo: true})
9+ deleteDialog.emptyMemo = true;
10+ deleteDialog.show();
11 } else {
12 console.log("autoSaveTimer triggered... updating the note!")
13 saveNote()
14@@ -204,7 +205,7 @@
15 id: deleteMemo
16 text: i18n.tr("Delete memo")
17 iconName: "delete"
18- onTriggered: PopupUtils.open(deleteDialog)
19+ onTriggered: deleteDialog.show()
20 visible: editMemo
21 }
22 Action {
23@@ -220,7 +221,8 @@
24 iconName: "back"
25 onTriggered: {
26 if (!canSave) {
27- PopupUtils.open(deleteDialog, memoPage, {emptyMemo: true})
28+ deleteDialog.emptyMemo = true;
29+ deleteDialog.show();
30 } else {
31 // Check if a saveNote request was made. If so, stop the timer and save before exiting the page.
32 if (autoSaveTimer.running) {
33@@ -256,33 +258,30 @@
34 }
35
36 // *** DIALOGS ***
37- Component {
38+ Dialog {
39 id: deleteDialog
40- Dialog {
41- id: deleteDialogue
42-
43- property bool emptyMemo: false
44-
45- title: emptyMemo ? i18n.tr("Empty memo") : i18n.tr("Delete memo")
46- text: emptyMemo ? i18n.tr("This memo has no content.") : i18n.tr("Are you sure?")
47-
48- Button {
49- text: i18n.tr("Cancel")
50- gradient: UbuntuColors.greyGradient
51- onClicked: PopupUtils.close(deleteDialogue)
52- visible: !emptyMemo
53- }
54- Button {
55- text: i18n.tr("Delete")
56- color: UbuntuColors.orange
57- onClicked: {
58- PopupUtils.close(deleteDialogue)
59- pageStack.pop();
60- pageStack.push(mainPage)
61- notes.deleteNote(index)
62-
63- root.showNotification(i18n.tr("Memo deleted!"))
64- }
65+
66+ property bool emptyMemo: false
67+
68+ title: emptyMemo ? i18n.tr("Empty memo") : i18n.tr("Delete memo")
69+ text: emptyMemo ? i18n.tr("This memo has no content.") : i18n.tr("Are you sure?")
70+
71+ Button {
72+ text: i18n.tr("Cancel")
73+ gradient: UbuntuColors.greyGradient
74+ onClicked: deleteDialog.hide()
75+ visible: !emptyMemo
76+ }
77+ Button {
78+ text: i18n.tr("Delete")
79+ color: UbuntuColors.orange
80+ onClicked: {
81+ deleteDialog.hide()
82+ pageStack.pop();
83+ pageStack.push(mainPage)
84+ notes.deleteNote(index)
85+
86+ root.showNotification(i18n.tr("Memo deleted!"))
87 }
88 }
89 }
90
91=== modified file 'po/quick-memo.pot'
92--- po/quick-memo.pot 2014-11-06 05:09:59 +0000
93+++ po/quick-memo.pot 2015-01-17 19:46:33 +0000
94@@ -8,7 +8,7 @@
95 msgstr ""
96 "Project-Id-Version: \n"
97 "Report-Msgid-Bugs-To: \n"
98-"POT-Creation-Date: 2014-11-06 06:08+0100\n"
99+"POT-Creation-Date: 2015-01-17 20:43+0100\n"
100 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
101 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
102 "Language-Team: LANGUAGE <LL@li.org>\n"
103@@ -54,11 +54,11 @@
104 msgid "A big thanks to:"
105 msgstr ""
106
107-#: ../app/components/AboutPage.qml:153
108+#: ../app/components/AboutPage.qml:158
109 msgid "Copyright"
110 msgstr ""
111
112-#: ../app/components/AboutPage.qml:185
113+#: ../app/components/AboutPage.qml:190
114 msgid "Close"
115 msgstr ""
116
117@@ -72,7 +72,7 @@
118
119 #: ../app/components/ColorDialog.qml:151
120 #: ../app/components/EditMemoPage.qml:270
121-#: ../app/components/EditMemoPage.qml:299 ../app/components/MainPage.qml:283
122+#: ../app/components/EditMemoPage.qml:298 ../app/components/MainPage.qml:283
123 #: ../app/components/MultiSelectionHandler.qml:33
124 msgid "Cancel"
125 msgstr ""
126@@ -91,7 +91,7 @@
127
128 #. TRANSLATORS: This is a custom text for the "enter" key of
129 #. the on-screen keyboard (max 4 char, so it's not elided)
130-#: ../app/components/EditMemoPage.qml:83 ../app/components/ListManager.qml:229
131+#: ../app/components/EditMemoPage.qml:83 ../app/components/ListManager.qml:287
132 msgid "Next"
133 msgstr ""
134
135@@ -104,15 +104,15 @@
136 msgid "Last update: %1"
137 msgstr ""
138
139-#: ../app/components/EditMemoPage.qml:190
140+#: ../app/components/EditMemoPage.qml:191
141 msgid "Memo saved!"
142 msgstr ""
143
144-#: ../app/components/EditMemoPage.qml:196
145+#: ../app/components/EditMemoPage.qml:197
146 msgid "Save"
147 msgstr ""
148
149-#: ../app/components/EditMemoPage.qml:205
150+#: ../app/components/EditMemoPage.qml:206
151 #: ../app/components/EditMemoPage.qml:266 ../app/components/MainPage.qml:240
152 #: ../app/components/MainPage.qml:279
153 msgid "Delete memo"
154@@ -120,17 +120,17 @@
155 msgstr[0] ""
156 msgstr[1] ""
157
158-#: ../app/components/EditMemoPage.qml:212 ../app/components/MainPage.qml:233
159+#: ../app/components/EditMemoPage.qml:213 ../app/components/MainPage.qml:233
160 msgid "Change memo color"
161 msgstr ""
162
163-#: ../app/components/EditMemoPage.qml:238 ../app/components/MainPage.qml:268
164+#: ../app/components/EditMemoPage.qml:240 ../app/components/MainPage.qml:268
165 msgid "Memo updated!"
166 msgid_plural "Memos updated!"
167 msgstr[0] ""
168 msgstr[1] ""
169
170-#: ../app/components/EditMemoPage.qml:253
171+#: ../app/components/EditMemoPage.qml:255
172 msgid "Memo aborted!"
173 msgstr ""
174
175@@ -156,15 +156,15 @@
176 msgstr[0] ""
177 msgstr[1] ""
178
179+#: ../app/components/EditMemoPage.qml:294
180+msgid "Discard changes?"
181+msgstr ""
182+
183 #: ../app/components/EditMemoPage.qml:295
184-msgid "Discard changes?"
185-msgstr ""
186-
187-#: ../app/components/EditMemoPage.qml:296
188 msgid "Your memo will be PERMANENTLY lost."
189 msgstr ""
190
191-#: ../app/components/EditMemoPage.qml:304
192+#: ../app/components/EditMemoPage.qml:303
193 msgid "Go back!"
194 msgstr ""
195
196@@ -177,11 +177,11 @@
197 msgstr ""
198
199 #. TRANSLATORS: Text of a button used for add an item in the To-do list.
200-#: ../app/components/ListManager.qml:96
201+#: ../app/components/ListManager.qml:98
202 msgid "Add item"
203 msgstr ""
204
205-#: ../app/components/ListManager.qml:229
206+#: ../app/components/ListManager.qml:287
207 msgid "Add"
208 msgstr ""
209

Subscribers

People subscribed via source and target branches

to all changes: