Merge lp:~verzegnassi-stefano/openstore/add-translations into lp:openstore

[Stefano Verzegnassi]

* Fixed wrong UBUNTU_TRANSLATION_SOURCES path
* Added translation template

* Fixed wrong UBUNTU_TRANSLATION_SOURCES path
* Added translation template

[Marius Gripsgard  (mariogrip)]

Looks good to me

review: Approve

[Brian Douglass (bhdouglass)]

Stefano, I made some suggestions/comments on the strings. I know that's not exactly part of the merge request, but I figured we could get this out of the way before we get translators translating the strings.

[lp:~verzegnassi-stefano/openstore/add-translations]

29. By Stefano Verzegnassi on 2017-05-20

Updated translations as per Brian's merge review. Removed 'OpenStore' string from translations since it shouldn't be translatable

30. By Stefano Verzegnassi on 2017-05-20

Added a few TRANSLATORS comments

[Stefano Verzegnassi (verzegnassi-stefano)]

Fixed! Let me know if it looks okay now! :)

[Brian Douglass (bhdouglass)]

Looks great!

review: Approve

=== modified file 'openstore.pro'
--- openstore.pro	2016-04-23 15:00:42 +0000
+++ openstore.pro	2017-05-20 10:15:00 +0000
@@ -22,8 +22,8 @@
 # template is created in po/template.pot, to create a
 # translation copy the template to e.g. de.po and edit the sources
 UBUNTU_TRANSLATION_SOURCES+= \
-    $$files(app/*.qml,true) \
-    $$files(app/*.js,true)
+    $$files(openstore/*.qml,true) \
+    $$files(openstore/*.js,true)
 
 # specifies all translations files and makes sure they are
 # compiled and installed into the right place in the click package

=== modified file 'openstore/AppDetailsPage.qml'
--- openstore/AppDetailsPage.qml	2017-05-08 18:41:35 +0000
+++ openstore/AppDetailsPage.qml	2017-05-20 10:15:00 +0000
@@ -123,7 +123,7 @@
                 }
                 ListItemLayout {
                     anchors.centerIn: parent
-                    subtitle.text: i18n.tr("This software requires extra privileges. See below for details.")
+                    subtitle.text: i18n.tr("This app has access to restricted system data, see below for details.")
                     subtitle.color: UbuntuColors.red
                     subtitle.maximumLineCount: 2
                     subtitle.wrapMode: Text.WordWrap
@@ -269,6 +269,7 @@
                 ListItemLayout {
                     id: changelogLayout
                     property bool showAll: false
+                    // TRANSLATORS: Title of the changelog section
                     title.text: i18n.tr("What's New")
                     subtitle.text: app.changelog
                     subtitle.textSize: Label.Small
@@ -315,7 +316,7 @@
                 divider.visible: false
                 ListItemLayout {
                     anchors.centerIn: parent
-                    title.text: i18n.tr("License") || i18n.tr("<i>N/A</i>")
+                    title.text: i18n.tr("License") || "<i>" + i18n.tr("N/A") + "</i>"
                     subtitle.text: app.license
                 }
             }
@@ -324,7 +325,7 @@
                 onClicked: Qt.openUrlExternally(app.source)
                 ListItemLayout {
                     anchors.centerIn: parent
-                    title.text: i18n.tr("Source Code") || i18n.tr("<i>N/A</i>")
+                    title.text: i18n.tr("Source Code") || "<i>" + i18n.tr("N/A") + "</i>"
                     subtitle.text: app.source
                     ProgressionSlot { visible: app.source }
                 }
@@ -347,6 +348,7 @@
                 }
                 ListItemLayout {
                     anchors.centerIn: parent
+                    // TRANSLATORS: This is the button that shows a list of all the packages from the same author. %1 is the name of the author.
                     title.text: i18n.tr("More from %1").arg(app.author)
                     ProgressionSlot {}
                 }
@@ -370,6 +372,7 @@
                 ListItemLayout {
                     anchors.centerIn: parent
                     // FIXME: app.category is not localized.
+                    // TRANSLATORS: This is the button that shows a list of all the other packages in the same category. %1 is the name of the category.
                     title.text: i18n.tr("Other apps in %1").arg(app.category)
                     ProgressionSlot {}
                 }
@@ -501,7 +504,7 @@
                                                       .replace("video_files", "<font color=\"#ED3146\">music_files_read</font>")
                                 }
 
-                                return i18n.tr("<i>none required</i>")
+                                return "<i>" + i18n.tr("none required") + "</i>"
                             }
                         }
 
@@ -519,7 +522,7 @@
                             }
 
                             title.text: i18n.tr("Read paths")
-                            subtitle.text: readpaths || i18n.tr("<i>none</i>")
+                            subtitle.text: readpaths || "<i>" + i18n.tr("none") + "</i>"
                             subtitle.maximumLineCount: Number.MAX_VALUE
                         }
 
@@ -536,7 +539,7 @@
                             }
 
                             title.text: i18n.tr("Write paths")
-                            subtitle.text: writepaths || i18n.tr("<i>none</i>")
+                            subtitle.text: writepaths || "<i>" + i18n.tr("none") + "</i>"
                             subtitle.maximumLineCount: Number.MAX_VALUE
                         }
 
@@ -571,8 +574,8 @@
             // TRANSLATORS: %1 is the size of a file, expressed in kB
             return i18n.tr("%1 kB").arg(parseInt(size / s));
 
-        // TRANSLATORS: %1 is the size of a file, expressed in byte
-        return i18n.tr("%1 byte").arg(size);
+        // TRANSLATORS: %1 is the size of a file, expressed in bytes
+        return i18n.tr("%1 bytes").arg(size);
     }
 
     function includesUnconfinedLocations(paths) {

=== modified file 'openstore/FilteredAppView.qml'
--- openstore/FilteredAppView.qml	2017-05-04 16:17:19 +0000
+++ openstore/FilteredAppView.qml	2017-05-20 10:15:00 +0000
@@ -98,7 +98,7 @@
             anchors.centerIn: parent
             active: view.count == 0
             sourceComponent: EmptyState {
-                title: rootItem.filterProperty == "category" ? i18n.tr("Nothing here yet") : i18n.tr("No result found.").arg(rootItem.filterPattern)
+                title: rootItem.filterProperty == "category" ? i18n.tr("Nothing here yet") : i18n.tr("No results found.").arg(rootItem.filterPattern)
                 subTitle: rootItem.filterProperty == "category" ? i18n.tr("No app has been released in this department yet.") : i18n.tr("Try with a different search.")
                 iconName: rootItem.filterProperty == "category" ? "ubuntu-store-symbolic" : "search"
                 anchors.centerIn: parent

=== modified file 'openstore/Main.qml'
--- openstore/Main.qml	2017-05-05 22:21:39 +0000
+++ openstore/Main.qml	2017-05-20 10:15:00 +0000
@@ -139,7 +139,7 @@
         Page {
             id: mainPage
             header: PageHeader {
-                title: i18n.tr("Open Store")
+                title: "OpenStore"  // This is the name of the store - no need for translation.
                 automaticHeight: false
 
                 leadingActionBar.actions: Action {

=== modified file 'openstore/SearchPage.qml'
--- openstore/SearchPage.qml	2017-05-04 16:17:19 +0000
+++ openstore/SearchPage.qml	2017-05-20 10:15:00 +0000
@@ -57,7 +57,7 @@
                 name: "search"
             }
 
-            placeholderText: i18n.tr("search in OpenStore...")
+            placeholderText: i18n.tr("Search in OpenStore...")
             onTextChanged: view.search(text)
             Component.onCompleted: view.search(text)
 

=== added directory 'po'
=== added file 'po/openstore.openstore-team.pot'
--- po/openstore.openstore-team.pot	1970-01-01 00:00:00 +0000
+++ po/openstore.openstore-team.pot	2017-05-20 10:15:00 +0000
@@ -0,0 +1,210 @@
+# SOME DESCRIPTIVE TITLE.
+# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
+# This file is distributed under the same license as the PACKAGE package.
+# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
+#
+#, fuzzy
+msgid ""
+msgstr ""
+"Project-Id-Version: PACKAGE VERSION\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2017-05-20 10:14+0000\n"
+"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
+"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
+"Language-Team: LANGUAGE <[e-mail]>\n"
+"Language: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=CHARSET\n"
+"Content-Transfer-Encoding: 8bit\n"
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:79
+msgid "Upgrade"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:79
+msgid "Install"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:89
+msgid "Remove"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:126
+msgid "This app has access to restricted system data, see below for details."
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:251
+msgid "Description"
+msgstr ""
+
+#. TRANSLATORS: Title of the changelog section
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:273
+msgid "What's New"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:291
+msgid "Packager/Publisher"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:292
+msgid "OpenStore team"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:300
+msgid "Installed version"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:310
+msgid "Latest available version"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:319
+msgid "License"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:319
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:328
+msgid "N/A"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:328
+msgid "Source Code"
+msgstr ""
+
+#. TRANSLATORS: This is the button that shows a list of all the packages from the same author. %1 is the name of the author.
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:352
+#, qt-format
+msgid "More from %1"
+msgstr ""
+
+#. TRANSLATORS: This is the button that shows a list of all the other packages in the same category. %1 is the name of the category.
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:376
+#, qt-format
+msgid "Other apps in %1"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:382
+msgid "Package contents"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:462
+msgid "AppArmor profile"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:490
+msgid "Permissions"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:507
+msgid "none required"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:524
+msgid "Read paths"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:525
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:542
+msgid "none"
+msgstr ""
+
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:541
+msgid "Write paths"
+msgstr ""
+
+#. TRANSLATORS: %1 is the size of a file, expressed in GB
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:565
+#, qt-format
+msgid "%1 GB"
+msgstr ""
+
+#. TRANSLATORS: %1 is the size of a file, expressed in MB
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:570
+#, qt-format
+msgid "%1 MB"
+msgstr ""
+
+#. TRANSLATORS: %1 is the size of a file, expressed in kB
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:575
+#, qt-format
+msgid "%1 kB"
+msgstr ""
+
+#. TRANSLATORS: %1 is the size of a file, expressed in bytes
+#: /tmp/add-translations/openstore/AppDetailsPage.qml:578
+#, qt-format
+msgid "%1 bytes"
+msgstr ""
+
+#: /tmp/add-translations/openstore/CategoriesPage.qml:24
+#: /tmp/add-translations/openstore/Main.qml:147
+msgid "Categories"
+msgstr ""
+
+#: /tmp/add-translations/openstore/DiscoverTab.qml:166
+msgid "Update available"
+msgstr ""
+
+#: /tmp/add-translations/openstore/DiscoverTab.qml:166
+msgid "Installed"
+msgstr ""
+
+#: /tmp/add-translations/openstore/FilteredAppView.qml:101
+msgid "Nothing here yet"
+msgstr ""
+
+#: /tmp/add-translations/openstore/FilteredAppView.qml:101
+msgid "No results found."
+msgstr ""
+
+#: /tmp/add-translations/openstore/FilteredAppView.qml:102
+msgid "No app has been released in this department yet."
+msgstr ""
+
+#: /tmp/add-translations/openstore/FilteredAppView.qml:102
+msgid "Try with a different search."
+msgstr ""
+
+#: /tmp/add-translations/openstore/Main.qml:153
+#: /tmp/add-translations/openstore/SearchPage.qml:29
+msgid "Search"
+msgstr ""
+
+#: /tmp/add-translations/openstore/Main.qml:160
+msgid "Discover"
+msgstr ""
+
+#: /tmp/add-translations/openstore/Main.qml:160
+msgid "My Apps"
+msgstr ""
+
+#: /tmp/add-translations/openstore/Main.qml:254
+msgid "Available updates"
+msgstr ""
+
+#: /tmp/add-translations/openstore/Main.qml:254
+msgid "Installed apps"
+msgstr ""
+
+#: /tmp/add-translations/openstore/Main.qml:272
+msgid "Fetching package list..."
+msgstr ""
+
+#: /tmp/add-translations/openstore/Main.qml:350
+#, qt-format
+msgid "Do you want to install %1?"
+msgstr ""
+
+#: /tmp/add-translations/openstore/SearchPage.qml:37
+msgid "Cancel"
+msgstr ""
+
+#: /tmp/add-translations/openstore/SearchPage.qml:60
+msgid "Search in OpenStore..."
+msgstr ""
+
+#: /tmp/add-translations/openstore/TextualButtonStyle.qml:46
+#: /tmp/add-translations/openstore/TextualButtonStyle.qml:54
+#: /tmp/add-translations/openstore/TextualButtonStyle.qml:60
+msgid "Pick"
+msgstr ""