Merge lp:~verterok/unity-scope-reddit/reddit-logging into lp:unity-scope-reddit

[Guillermo Gonzalez]

Add basic logging (replace print with logging)

Add basic logging (replace print with logging)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:4
http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-ci/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-amd64-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-armhf-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-i386-ci/7/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-reddit-ci/7/rebuild

review: Needs Fixing (continuous-integration)

[lp:~verterok/unity-scope-reddit/reddit-logging]

5. By Guillermo Gonzalez on 2013-09-25

fix test

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:5
http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-i386-ci/8

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-reddit-ci/8/rebuild

review: Approve (continuous-integration)

[David Callé (davidc3)]

+1

review: Approve

=== modified file 'src/unity_reddit_daemon.py'
--- src/unity_reddit_daemon.py	2013-08-14 14:52:46 +0000
+++ src/unity_reddit_daemon.py	2013-09-25 03:02:00 +0000
@@ -2,24 +2,25 @@
 # -*- coding: utf-8 -*-
 
 # Copyright (C) 2013 David Callé <[e-mail]>
-# This program is free software: you can redistribute it and/or modify it 
-# under the terms of the GNU General Public License version 3, as published 
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
 # by the Free Software Foundation.
-# 
-# This program is distributed in the hope that it will be useful, but 
-# WITHOUT ANY WARRANTY; without even the implied warranties of 
-# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR 
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
 # PURPOSE.  See the GNU General Public License for more details.
-# 
-# You should have received a copy of the GNU General Public License along 
+#
+# You should have received a copy of the GNU General Public License along
 # with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-from gi.repository import Unity, UnityExtras
-from gi.repository import Gio, GLib
+from gi.repository import Unity
+from gi.repository import Gio
 import urllib.parse
 import urllib.request
 import json
 import gettext
+import logging
 
 APP_NAME = 'unity-scope-reddit'
 LOCAL_PATH = '/usr/share/locale/'
@@ -65,6 +66,8 @@
       'field':Unity.SchemaFieldType.OPTIONAL}
 EXTRA_METADATA = [m1, m2, m3, m4, m5]
 
+logger = logging.getLogger("unity.scope.reddit")
+
 def search(search, filters):
     '''
     Any search method returning results as a list of tuples.
@@ -88,16 +91,16 @@
     else:
         search_cleaned = urllib.parse.quote(search.split('#')[0])
         uri = '%sr/%s/hot.json?limit=25' % (SEARCH_URI, search_cleaned)
-    print(uri)
     data = None
     try:
+        logger.debug("Request: %s", uri)
         hdr = { 'User-Agent' : 'unity-scope-reddit' }
-        req = urllib.request.Request(url=uri, 
+        req = urllib.request.Request(url=uri,
                                      headers=hdr)
         response = urllib.request.urlopen(req).read()
         data = json.loads(response.decode('utf-8'))
-    except Exception as error:
-        print(error)
+    except Exception:
+        logger.exception("Error while fetching: %r", uri)
         return results
     if not data or not 'data' in data:
         return results
@@ -160,8 +163,9 @@
                 if not 'dnd_uri' in i or not i['dnd_uri'] or i['dnd_uri'] == '':
                     i['dnd_uri'] = i['uri']
                 result_set.add_result(**i)
-        except Exception as error:
-            print (error)
+        except Exception:
+            logger.exception("Error while building result set.")
+
 
 class Preview (Unity.ResultPreviewer):
 
@@ -225,7 +229,7 @@
         '''
         fs = Unity.FilterSet.new ()
 #        if FILTERS:
-#            
+#
         return fs
 
     def do_get_group_name (self):

=== modified file 'tests/test_reddit.py'
--- tests/test_reddit.py	2013-08-13 16:30:30 +0000
+++ tests/test_reddit.py	2013-09-25 03:02:00 +0000
@@ -24,7 +24,7 @@
     def perform_query(self, query, filter_set = Unity.FilterSet.new()):
         result_set = ResultSet()
         ctx = Unity.SearchContext.create(query, 0, filter_set,
-                                         None, result_set, None)
+                                         {}, result_set, None)
         s = self.scope.create_search_for_query(ctx)
         s.run()
         return result_set