ols-jenkaas

Merge lp:~verterok/ols-jenkaas/change-sso-charm-container-to-xenial into lp:~ols-jenkaas-admins/ols-jenkaas/trunk

  1. change-sso-charm-container-to-xenial
  2. Merge into trunk
Proposed by Guillermo Gonzalez
Status: Merged
Merged at revision: 638
Proposed branch: lp:~verterok/ols-jenkaas/change-sso-charm-container-to-xenial
Merge into: lp:~ols-jenkaas-admins/ols-jenkaas/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
jobs/canonical-identity-provider.yaml (+1/-1)
To merge this branch: bzr merge lp:~verterok/ols-jenkaas/change-sso-charm-container-to-xenial
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+367790@code.launchpad.net

Commit message

change sso charm container to xenial

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

lgtm.

Those "u1-$release" containers are somewhat iffy since they're not per-project, I wonder why we're not building the charms on each project's container.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/canonical-identity-provider.yaml'
2--- jobs/canonical-identity-provider.yaml 2019-02-07 12:12:42 +0000
3+++ jobs/canonical-identity-provider.yaml 2019-05-22 17:06:48 +0000
4@@ -12,7 +12,7 @@
5 - project:
6 name: 'canonical-identity-provider-charm'
7 defaults: project
8- container: 'u1-trusty'
9+ container: 'u1-xenial'
10 setup: 'make bootstrap'
11 landing-tests: 'make test'
12 charm-store: 'canonical-identity-provider'

Subscribers

People subscribed via source and target branches