ols-jenkaas

Merge lp:~verterok/ols-jenkaas/add-codetree-to-snap-sideload-script into lp:~ols-jenkaas-admins/ols-jenkaas/trunk

  1. add-codetree-to-snap-sideload-script
  2. Merge into trunk
Proposed by Guillermo Gonzalez
Status: Merged
Merged at revision: 701
Proposed branch: lp:~verterok/ols-jenkaas/add-codetree-to-snap-sideload-script
Merge into: lp:~ols-jenkaas-admins/ols-jenkaas/trunk
Diff against target: 17 lines (+5/-3)
1 file modified
scripts/snap-sideload.sh (+5/-3)
To merge this branch: bzr merge lp:~verterok/ols-jenkaas/add-codetree-to-snap-sideload-script
Reviewer Review Type Date Requested Status
Maximiliano Bertacchini Approve
Online Services Jenkaas Administrators Pending
Review via email: mp+383169@code.launchpad.net

Commit message

support installing codetree using --classic in scripts/snap-sideload.sh

To post a comment you must log in.
Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/snap-sideload.sh'
2--- scripts/snap-sideload.sh 2020-04-14 21:38:39 +0000
3+++ scripts/snap-sideload.sh 2020-04-29 20:27:23 +0000
4@@ -29,8 +29,10 @@
5 sudo snap ack $TMP_DIR/$snap_file.assert
6 # FIXME: find a nice way to mark which snaps require classic instead of
7 # hardoding the check here
8- case $snap_file in
9- "charm"*) sudo snap install $TMP_DIR/$snap_file.snap --classic ;;
10- *) sudo snap install $TMP_DIR/$snap_file.snap ;;
11+ case $snap_file in
12+ "charm"* | "codetree"*)
13+ sudo snap install $TMP_DIR/$snap_file.snap --classic ;;
14+ *)
15+ sudo snap install $TMP_DIR/$snap_file.snap ;;
16 esac
17 done

Subscribers

People subscribed via source and target branches