loggerhead

Merge lp:~verterok/loggerhead/logging into lp:loggerhead

  1. logging
  2. Merge into trunk-rich
Proposed by Guillermo Gonzalez
Status: Merged
Merge reported by: Michael Hudson-Doyle
Merged at revision: 226
Proposed branch: lp:~verterok/loggerhead/logging
Merge into: lp:loggerhead
To merge this branch: bzr merge lp:~verterok/loggerhead/logging
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle Approve
Review via email: mp+1172@code.launchpad.net

This proposal supersedes a proposal from 2008-09-10.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote : Posted in a previous version of this proposal

I made some clean-up type changes in https://code.edge.launchpad.net/~mwhudson/loggerhead/logging.

I'm not sure that displaying "[(<class 'bzrlib.errors.NoSuchId'>, NoSuchId(), <traceback object at 0x1586680>)]" to the user really helps them very much. Can you maybe make this end of things a little nicer?

Other than that, it looks good!

Revision history for this message
Guillermo Gonzalez (verterok) wrote : Posted in a previous version of this proposal

Hi Michael,
Thanks for the review (and the cleanup :-)
Fully agree, showing <class 'bzrlib.errors.NoSuchId'>... to the user isn't ok.
it' was just an example :-p
I'll improve the template and controller, and resubmit.

Thanks,

lp:~verterok/loggerhead/logging updated
230. By Guillermo Gonzalez

 * merge with trunk

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote : Posted in a previous version of this proposal

Looks good, I cleaned up a few things and merged it.

review: Approve ( )
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

In the right place :)

Looks good, I cleaned up a few things and merged it.

review: Approve

Subscribers

People subscribed via source and target branches