Merge lp:~verterok/charms/trusty/tanuki-spec-manager/sane_db-relation-changed_restarts into lp:~tanuki/charms/trusty/tanuki-spec-manager/trunk
Proposed by
Guillermo Gonzalez
Status: | Merged |
---|---|
Approved by: | Guillermo Gonzalez |
Approved revision: | 39 |
Merged at revision: | 34 |
Proposed branch: | lp:~verterok/charms/trusty/tanuki-spec-manager/sane_db-relation-changed_restarts |
Merge into: | lp:~tanuki/charms/trusty/tanuki-spec-manager/trunk |
Diff against target: |
150 lines (+69/-30) 2 files modified
hooks/actions.py (+68/-27) hooks/services.py (+1/-3) |
To merge this branch: | bzr merge lp:~verterok/charms/trusty/tanuki-spec-manager/sane_db-relation-changed_restarts |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Celso Providelo (community) | Approve | ||
Review via email: mp+276530@code.launchpad.net |
Commit message
Fix handling of db-relation-changed hook and avoid pointless restarts.
Description of the change
"reuse" some knowledge from landscape charm on how handle db-relation-changed hook and avoid pointless restarts.
This is to fix the case of adding a new service/unit relation to postgresql and getting a db-relation-changed triggered on all already related services, with a change on allowed-units field which shouldn't trigger a restart on all other services.
To post a comment you must log in.
Thanks, Guillo.
I am happy to try it on staging and if it works fine propagate the Restart( ManagerCallback ) to other charms, since it's very portable.