Merge lp:~verterok/charms/trusty/tanuki-spec-manager/be-more-gentle-on-db-relation-changes into lp:~tanuki/charms/trusty/tanuki-spec-manager/trunk
Proposed by
Guillermo Gonzalez
Status: | Merged |
---|---|
Approved by: | Guillermo Gonzalez |
Approved revision: | 34 |
Merged at revision: | 33 |
Proposed branch: | lp:~verterok/charms/trusty/tanuki-spec-manager/be-more-gentle-on-db-relation-changes |
Merge into: | lp:~tanuki/charms/trusty/tanuki-spec-manager/trunk |
Diff against target: |
125 lines (+37/-17) 2 files modified
hooks/actions.py (+33/-17) hooks/services.py (+4/-0) |
To merge this branch: | bzr merge lp:~verterok/charms/trusty/tanuki-spec-manager/be-more-gentle-on-db-relation-changes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Celso Providelo (community) | Approve | ||
Review via email: mp+276254@code.launchpad.net |
Commit message
- improve ConnCheckRelati
- add config file (service.conf) checksum verification in custom restart function, to avoid pointless restarts
Description of the change
- improve ConnCheckRelati
- add config file (service.conf) checksum verification in custom restart function, to avoid pointless restarts
To post a comment you must log in.
Guillermo,
Thanks for working on this.
Preserving old config and preventing restart on insufficient DB-information looks sane and appropriate for this.
We can explore this behaviour in staging (by poking pgsql weirdly) and verify spec-manager stands up until it's back.