Merge lp:~verterok/charms/trusty/tanuki-result-enum-worker/negate-nrpe-check-when-disabled into lp:~tanuki/charms/trusty/tanuki-result-enum-worker/trunk

[Guillermo Gonzalez]

Negate file_age check when the worker is disabled as a workaround until we get a better/different way of checking worker health.

Negate file_age check when the worker is disabled.

This is a temporary fix/workaround until we get a better/different way of checking worker health.

[Celso Providelo (cprov)]

Guillermo,

Actually, nagios `negate` plugin is not bad for deactivated services, while they exist it kind of make sense to check they are usable (load, memory, disk, etc) and are indeed not running. So, not bad at all.

I suspect you would have to refer to the negate complete path in config, "/usr/lib/nagios/plugins/negate", but fell free to ignore me if you have already checked it works in out instances.

[]

review: Approve

[Guillermo Gonzalez (verterok)]

> Guillermo,
>
> Actually, nagios `negate` plugin is not bad for deactivated services, while
> they exist it kind of make sense to check they are usable (load, memory, disk,
> etc) and are indeed not running. So, not bad at all.
>
> I suspect you would have to refer to the negate complete path in config,
> "/usr/lib/nagios/plugins/negate", but fell free to ignore me if you have
> already checked it works in out instances.
The nrpe helper fills the full path for negate, so there is no need to specify the full path.

=== modified file 'hooks/actions.py'
--- hooks/actions.py	2015-09-01 04:57:02 +0000
+++ hooks/actions.py	2015-09-07 18:53:42 +0000
@@ -124,11 +124,15 @@
 def nrpe_external_master_relation(service_name):
     """Configure the nrpe-external-master relation."""
     nrpe_compat = nrpe.NRPE()
-
+    config = hookenv.config()
+    check_cmd = ('/usr/lib/nagios/plugins/check_file_age -c 60 '
+                 '{}'.format(NAGIOS_CONTROL_FILEPATH))
+    if not config.get('active'):
+        check_cmd = 'negate {}'.format(check_cmd)
     nrpe_compat.add_check(
         shortname='result_worker_status',
         description='Worker app or worker rabbitmq check.',
-        check_cmd='check_file_age -c 60 %s' % NAGIOS_CONTROL_FILEPATH
+        check_cmd=check_cmd
     )
     nrpe_compat.write()