Code review comment for lp:~verterok/charms/trusty/mongodb/fix-data_directory-migration

Revision history for this message
Adam Israel (aisrael) wrote :

Hi Guillermo,

Thanks for your work on improving the mongodb charm! I had a chance to this merge proposal today and wanted to provide you with some feedback.

The changes you've made look to be straightforward, and I suspect that they work as intended, but I'd prefer to see a simple amulet test added to verify the migration works as expected. With that in place, I'd have no problem giving this my approval.

Thanks!

review: Needs Fixing

« Back to merge proposal