Code review comment for lp:~verterok/charms/trusty/elasticsearch/elasticsearch2_more-details-in-health-check

21:41 < noodles> verterok: Is nagios_health_color currently a config option (defaulting to green)? From memory it was, because otherwise if you're developing and using only one unit, the health will always be yellow?
21:42 < noodles> If you think that's unnecessary, we can probably remove the option (as it should only be used in dev, and worst-case, anyone upgrading will see it's removed with a config error)
21:44 < caio1982> atomatt: nice! i will take a look!
21:44 < verterok> noodles: didn't know it is a config, assumed it was the way ES reported status
21:44 < verterok> let me check
21:45 < verterok> noodles: oh, I understand now
21:46 < verterok> noodles: I can tweak the script to accept a custom "OK" status if you think it's needed.
21:47 < noodles> verterok: If that's simple enough, it'll mean maintaining the ability to deploy just one unit in a devel spec without error, but it's not that important . Fine either way. The script is a great improvement :)
21:48 < verterok> noodles: will play with the script tomorrow and ping you back when it's done. thanks
21:48 < noodles> verterok: Ack - or if it's an issue, fine to just remove that config option. No need to check back - just land with either.