Merge lp:~verterok/canonical-identity-provider/charm_switch-python-version into lp:~ubuntuone-pqm-team/canonical-identity-provider/charm

[Guillermo Gonzalez]

Add switch-python-version action to replace venv on a running unit

[John Paraskevopoulos (quantifics)]

let's go and flip the switch!

review: Approve

[Otto Co-Pilot (otto-copilot)]

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider_charm/29/

[Otto Co-Pilot (otto-copilot)]

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider_charm/30/

[lp:~verterok/canonical-identity-provider/charm_switch-python-version]

108. By Guillermo Gonzalez on 2022-08-30

fix lint

=== added symlink 'actions/switch-python-version'
=== target is '../hooks/hooks.py'
=== modified file 'hooks/hooks.py'
--- hooks/hooks.py	2019-04-30 20:50:18 +0000
+++ hooks/hooks.py	2022-08-30 16:42:00 +0000
@@ -2,8 +2,11 @@
 
 import os
 import sys
+import shutil
+import traceback
 import charmhelpers.contrib.ansible
 import charmhelpers.payload.execd
+from charmhelpers.core import hookenv
 
 # Create the hooks helper which automatically registers the
 # required hooks based on the available tags in your playbook.
@@ -69,6 +72,23 @@
     return {'branch': branch}
 
 
[e-mail]()
+def switch_python_version(python_version, build_label):
+    # delete the venv and trigger the creation of a new one
+    conf = hookenv.config()
+    venv_dir = (
+        '/srv/{hostname}/{deployment}/code/{build_label}/env'
+    ).format(**conf)
+    try:
+        if os.path.exists(venv_dir):
+            shutil.rmtree(venv_dir)
+    except Exception:
+        # something went terribly wrong, print something and re-raise
+        print(traceback.format_exc())
+        raise
+    return {'python_version': python_version, 'build_label': build_label}
+
+
 if __name__ == "__main__":
     # workaround install.real script name
     if 'install.real' in sys.argv[0]:

=== modified file 'playbook.yaml'
--- playbook.yaml	2022-07-19 21:31:55 +0000
+++ playbook.yaml	2022-08-30 16:42:00 +0000
@@ -97,6 +97,7 @@
         - wsgi-file-relation-changed
         - preload
         - migrate
+        - switch-python-version
       stat: path={{ current_dir }}
       register: payload
 
@@ -145,10 +146,12 @@
         - preload
         - migrate
         - install
+        - switch-python-version
       pip:
         requirements: "{{ current_dir }}/requirements.txt"
         virtualenv: "{{ venv }}"
         virtualenv_command: "/usr/bin/virtualenv --never-download"
+        virtualenv_python: "{{ python_version | default('python2.7') }}"
         extra_args: "--no-index  --find-links={{ wheel_dir }}"
         virtualenv_site_packages: yes
       when: build_label != "" and payload.stat.exists
@@ -159,6 +162,7 @@
         - memcached-relation-changed
         - memcached-relation-departed
         - migrate
+        - switch-python-version
       template:
         src: "{{ charm_dir }}/templates/settings.py.j2"
         dest: "{{ conf_dir }}/test_settings.py"
@@ -170,6 +174,7 @@
         - memcached-relation-changed
         - memcached-relation-departed
         - migrate
+        - switch-python-version
       become: yes
       become_user: "{{ user }}"
       command: "{{ python }} {{ manage }} check --pythonpath={{ conf_dir }} --settings=test_settings"
@@ -183,6 +188,7 @@
         - memcached-relation-changed
         - memcached-relation-departed
         - migrate
+        - switch-python-version
       command: mv "{{ conf_dir }}/test_settings.py" "{{ conf_dir }}/settings.py"
       when: build_label != "" and payload.stat.exists
       notify: Restart wsgi
@@ -193,6 +199,7 @@
         - memcached-relation-changed
         - memcached-relation-departed
         - migrate
+        - switch-python-version
       command: rm -f {{ conf_dir }}/test_settings.*
       when: build_label != "" and payload.stat.exists