Merge lp:~verifydtapn-contributers/verifydtapn/Cleanup into lp:verifydtapn

Proposed by Peter Gjøl Jensen
Status: Merged
Approved by: Jiri Srba
Approved revision: no longer in the source branch.
Merged at revision: 277
Proposed branch: lp:~verifydtapn-contributers/verifydtapn/Cleanup
Merge into: lp:verifydtapn
Diff against target: 85 lines (+5/-47)
4 files modified
src/DiscreteVerification/DataStructures/EncodingStructure.cpp (+0/-14)
src/DiscreteVerification/DataStructures/NonStrictMarking.cpp (+0/-15)
src/DiscreteVerification/DataStructures/PData.cpp (+0/-16)
src/DiscreteVerification/DataStructures/PData.h (+5/-2)
To merge this branch: bzr merge lp:~verifydtapn-contributers/verifydtapn/Cleanup
Reviewer Review Type Date Requested Status
Peter Gjøl Jensen Approve
Mathias Grund Sørensen Approve
Jiri Srba Approve
Jakob Taankvist Approve
Review via email: mp+157864@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jakob Taankvist (jakob-taankvist) :
review: Approve
Revision history for this message
Jiri Srba (srba) :
review: Approve
Revision history for this message
Mathias Grund Sørensen (mathias.grund) :
review: Approve
277. By Jiri Srba

merged in the cleanup branch

Revision history for this message
Peter Gjøl Jensen (peter-gjoel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'src/DiscreteVerification/DataStructures/EncodingStructure.cpp'
2--- src/DiscreteVerification/DataStructures/EncodingStructure.cpp 2012-12-07 09:12:40 +0000
3+++ src/DiscreteVerification/DataStructures/EncodingStructure.cpp 1970-01-01 00:00:00 +0000
4@@ -1,14 +0,0 @@
5-/*
6- * File: Encoding.cpp
7- * Author: floop
8- *
9- * Created on 27. oktober 2012, 12:36
10- */
11-
12-#include "EncodingStructure.h"
13-namespace VerifyTAPN {
14- namespace DiscreteVerification {
15-
16-
17- }
18-}
19\ No newline at end of file
20
21=== removed file 'src/DiscreteVerification/DataStructures/NonStrictMarking.cpp'
22--- src/DiscreteVerification/DataStructures/NonStrictMarking.cpp 2012-12-05 09:06:30 +0000
23+++ src/DiscreteVerification/DataStructures/NonStrictMarking.cpp 1970-01-01 00:00:00 +0000
24@@ -1,15 +0,0 @@
25-/*
26- * NonStrictMarking.cpp
27- *
28- * Created on: 29/02/2012
29- * Author: MathiasGS
30- */
31-
32-#include "NonStrictMarking.hpp"
33-
34-using namespace std;
35-
36-namespace VerifyTAPN {
37-namespace DiscreteVerification {
38-} /* namespace DiscreteVerification */
39-} /* namespace VerifyTAPN */
40
41=== removed file 'src/DiscreteVerification/DataStructures/PData.cpp'
42--- src/DiscreteVerification/DataStructures/PData.cpp 2012-12-07 09:12:40 +0000
43+++ src/DiscreteVerification/DataStructures/PData.cpp 1970-01-01 00:00:00 +0000
44@@ -1,16 +0,0 @@
45-/*
46- * File: PData.cpp
47- * Author: floop
48- *
49- * Created on 5. november 2012, 10:22
50- */
51-
52-#include <set>
53-
54-#include "PData.h"
55-namespace VerifyTAPN {
56- namespace DiscreteVerification {
57-
58-
59- }
60-}
61\ No newline at end of file
62
63=== modified file 'src/DiscreteVerification/DataStructures/PData.h'
64--- src/DiscreteVerification/DataStructures/PData.h 2013-02-15 17:12:45 +0000
65+++ src/DiscreteVerification/DataStructures/PData.h 2013-04-09 12:47:27 +0000
66@@ -18,14 +18,17 @@
67 // pointer containing enough data to reconstruct the stored data at any time!
68 template<typename T>
69 struct EncodingPointer {
70+ // The part of the encoding not being represented by the path in the PTrie
71 EncodingStructure<T*> encoding;
72+ // The coresponding node in the PTrie
73 unsigned int node;
74
75+ // empty constructor
76 EncodingPointer() {
77 };
78-
79- EncodingPointer(EncodingPointer<T> &en) : encoding(en.encoding.Clone()), node(en.node) {}; // possible mem-leak?
80
81+ // Construct a pointer with enough (persistent) data to recreate the marking.
82+ // The encoding is cloned as it is not persistant in the PTrie
83 EncodingPointer(EncodingStructure<T*> &en, unsigned int n) : encoding(en.Clone()), node(n) {
84 }
85 };

Subscribers

People subscribed via source and target branches